Skip to content

Added SQS Instrumentation#2637

Merged
AlexanderWert merged 5 commits intoelastic:mainfrom
AlexanderWert:aws-sqs
Aug 23, 2022
Merged

Added SQS Instrumentation#2637
AlexanderWert merged 5 commits intoelastic:mainfrom
AlexanderWert:aws-sqs

Conversation

@AlexanderWert
Copy link
Member

@AlexanderWert AlexanderWert commented May 18, 2022 •
edited
Loading

Closes #1639

Adds instrumentation for SQS messaging.

  • handle span links
@AlexanderWert AlexanderWert requested a review from eyalkoren May 18, 2022 10:09
@ghost
Copy link

ghost commented May 18, 2022 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-23T08:16:01.088+0000

  • Duration: 59 min 42 sec

Test stats 🧪

Test Results
Failed 0
Passed 3130
Skipped 36
Total 3166

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)
@AlexanderWert AlexanderWert force-pushed the aws-sqs branch 2 times, most recently from 98b4d80 to 3b6065f Compare May 18, 2022 13:27
@eyalkoren eyalkoren added this to the 8.4 milestone May 31, 2022
@AlexanderWert AlexanderWert requested review from jackshirazi and removed request for eyalkoren June 13, 2022 13:42
@AlexanderWert AlexanderWert modified the milestones: 8.4, 8.5 Jul 25, 2022
@AlexanderWert
Added SQS Instrumentation
07cbb60 
fixed destination service resource

added message processing spans,  refactored test classes

Extended destination serialization test to cover multiple content combinations

Removed lazy instantiation of helper objects
@AlexanderWert AlexanderWert marked this pull request as ready for review August 17, 2022 11:04
@github-actions
Copy link

github-actions bot commented Aug 17, 2022

/test
@AlexanderWert
Removed Nullable annotation on singleton instances.
f5bb17a 
Replaced boxed Long with primitive type on getMessageAge.
@jackshirazi
Copy link
Contributor

jackshirazi commented Aug 23, 2022

Excellent work! Just need to add a CHANGELOG entry (and possibly a supported tech entry) and you're done!
@AlexanderWert AlexanderWert enabled auto-merge (squash) August 23, 2022 08:27
@AlexanderWert AlexanderWert merged commit fab4f04 into elastic:main Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-java

3 participants

@AlexanderWert @jackshirazi @eyalkoren