Skip to content

remove transaction.status from otel transactions#2660

Merged
SylvainJuge merged 4 commits intoelastic:mainfrom
SylvainJuge:otel-bridge-do-not-infer-transaction-result
Jun 2, 2022
Merged

remove transaction.status from otel transactions#2660
SylvainJuge merged 4 commits intoelastic:mainfrom
SylvainJuge:otel-bridge-do-not-infer-transaction-result

Conversation

@SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Jun 2, 2022

What does this PR do?

Removes the transaction.result field value for transactions that are created through the OTel bridge.

When the value is set in the intake protocol, APM server currently keeps the provided value, removing it allows to infer the value from OTel attributes values and stay consistent with native OTLP intake.

Checklist

Copy link
Member

@felixbarny felixbarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does this require changes in the spec?

…rc/test/java/specs/OTelBridgeStepsDefinitions.java

Co-authored-by: Felix Barnsteiner <felixbarny@users.noreply.github.com>
@ghost
Copy link

ghost commented Jun 2, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-02T15:33:23.811+0000

  • Duration: 48 min 29 sec

Test stats 🧪

Test Results
Failed 0
Passed 2932
Skipped 22
Total 2954

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@SylvainJuge SylvainJuge marked this pull request as ready for review June 2, 2022 14:51
@github-actions
Copy link

github-actions bot commented Jun 2, 2022

/test

@SylvainJuge
Copy link
Member Author

Does this require changes in the spec?

Yes : elastic/apm#649

@SylvainJuge SylvainJuge enabled auto-merge (squash) June 2, 2022 15:17
@SylvainJuge SylvainJuge mentioned this pull request Jun 2, 2022
7 tasks
@SylvainJuge SylvainJuge disabled auto-merge June 2, 2022 15:30
@SylvainJuge SylvainJuge enabled auto-merge (squash) June 2, 2022 15:33
@SylvainJuge SylvainJuge merged commit d1aca85 into elastic:main Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants