Skip to content

document the metric_set_limit option#2717

Merged
jackshirazi merged 3 commits intoelastic:mainfrom
jackshirazi:document-metric_set_limit
Jul 21, 2022
Merged

document the metric_set_limit option#2717
jackshirazi merged 3 commits intoelastic:mainfrom
jackshirazi:document-metric_set_limit

Conversation

@jackshirazi
Copy link
Contributor

What does this PR do?

document the metric_set_limit option per comments in #2148 - making the option not internal and expand the documentation

@ghost
Copy link

ghost commented Jul 19, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-21T11:02:36.441+0000

  • Duration: 48 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 3054
Skipped 36
Total 3090

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@eyalkoren eyalkoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Transaction names is only one specific case of what's affecting the number of metricsets. The general factor that determine metricsets cardinality is the metrics labels (see MetricRegistryTest). So I propose talking about labels, but saying that it's better to reduce cardinality rather than increasing the limit is good, in which case you can mention transaction name as one option
  2. You need to run ConfigurationExporterTest for this to be actually added to the documentation
@jackshirazi
Copy link
Contributor Author

Thanks @eyalkoren , is the latest version good enough, or still further changes needed?

@jackshirazi jackshirazi requested a review from eyalkoren July 20, 2022 16:52
@jackshirazi jackshirazi merged commit 003ca7b into elastic:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants