document the metric_set_limit option#2717
Merged
jackshirazi merged 3 commits intoelastic:mainfrom Jul 21, 2022
Merged
Conversation
eyalkoren
suggested changes
Jul 20, 2022
Contributor
eyalkoren
left a comment
There was a problem hiding this comment.
- Transaction names is only one specific case of what's affecting the number of metricsets. The general factor that determine metricsets cardinality is the metrics labels (see
MetricRegistryTest). So I propose talking about labels, but saying that it's better to reduce cardinality rather than increasing the limit is good, in which case you can mention transaction name as one option - You need to run
ConfigurationExporterTestfor this to be actually added to the documentation
Contributor
Author
|
Thanks @eyalkoren , is the latest version good enough, or still further changes needed? |
eyalkoren
approved these changes
Jul 21, 2022
…gent-java into document-metric_set_limit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
document the metric_set_limit option per comments in #2148 - making the option not
internaland expand the documentation