Interrupted thread callsite resolution#2752
Merged
SylvainJuge merged 5 commits intoelastic:mainfrom Aug 31, 2022
Merged
Conversation
felixbarny
reviewed
Aug 23, 2022
apm-agent-core/src/test/java/co/elastic/apm/agent/util/PackageScannerTest.java
Outdated
Show resolved
Hide resolved
apm-agent-core/src/main/java/co/elastic/apm/agent/util/PackageScanner.java
Outdated
Show resolved
Hide resolved
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When an application thread was interrupted and the
interruptedstatus hasn't been cleared, it makes the instrumentation call site resolution fail withClosedByInterruptException, hence making the instrumentation fail and resolve to a no-op.When this happens, a stack trace similar to the following is visible in the agent logs;
A similar instance of this issue has already been reported in the forum here.
Checklist