Skip to content

Ignore few other agents#2766

Merged
SylvainJuge merged 5 commits intoelastic:mainfrom
SylvainJuge:ignore-appdynamics-agent
Sep 1, 2022
Merged

Ignore few other agents#2766
SylvainJuge merged 5 commits intoelastic:mainfrom
SylvainJuge:ignore-appdynamics-agent

Conversation

@SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Aug 31, 2022

What does this PR do?

AppDynamics agent is now using another package com.appdynamics. and thus our heuristic to ignore it should be updated, and we need to exclude at classloader level rather than class name package only.

While we are at it, we might also enhance heuristic for other known agents.

Checklist

  • This is a bugfix
    • manually testing with a problematic other vendor agent
    • I have updated CHANGELOG.asciidoc
    • I have added tests that would fail without this fix
@ghost
Copy link

ghost commented Aug 31, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-01T15:30:10.932+0000

  • Duration: 58 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 3132
Skipped 36
Total 3168

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@SylvainJuge SylvainJuge changed the title Ignore AppDynamics agent Sep 1, 2022
@SylvainJuge SylvainJuge marked this pull request as ready for review September 1, 2022 13:28
@github-actions
Copy link

github-actions bot commented Sep 1, 2022

/test

@SylvainJuge SylvainJuge enabled auto-merge (squash) September 1, 2022 15:30
@SylvainJuge SylvainJuge merged commit cbc2bc8 into elastic:main Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants