Skip to content

Added finagle Http client#2795

Merged
JonasKunz merged 7 commits intoelastic:mainfrom
JonasKunz:finagle-http-client
Nov 24, 2022
Merged

Added finagle Http client#2795
JonasKunz merged 7 commits intoelastic:mainfrom
JonasKunz:finagle-http-client

Conversation

@JonasKunz
Copy link
Contributor

@JonasKunz JonasKunz commented Sep 20, 2022

What does this PR do?

Add support for the finagle http client (#2794).
Works, as long as the HTTP call is made from a non-finagle thread context.
Otherwise, we will need support for the finagle context propagation mechanism.

Checklist

  • This is a new plugin
    • I have updated CHANGELOG.asciidoc
    • My code follows the style guidelines of this project
    • I have made corresponding changes to the documentation
    • I have added tests that prove my fix is effective or that my feature works
    • New and existing unit tests pass locally with my changes
    • I have updated supported-technologies.asciidoc
    • Added an API method or config option? Document in which version this will be introduced
    • Added an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident.
@ghost
Copy link

ghost commented Sep 20, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-24T10:39:07.278+0000

  • Duration: 60 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 3218
Skipped 39
Total 3257

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@JonasKunz JonasKunz marked this pull request as ready for review November 21, 2022 14:46
@github-actions
Copy link

/test

Copy link
Contributor

@jackshirazi jackshirazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it was painful to do

@JonasKunz JonasKunz enabled auto-merge (squash) November 24, 2022 09:06
@JonasKunz JonasKunz merged commit 4bbb558 into elastic:main Nov 24, 2022
@JonasKunz JonasKunz deleted the finagle-http-client branch November 24, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants