Add ability to change Naming Mode for spring-rabbit-plugin#3424
Merged
jackshirazi merged 9 commits intoelastic:mainfrom Feb 7, 2024
Merged
Add ability to change Naming Mode for spring-rabbit-plugin#3424jackshirazi merged 9 commits intoelastic:mainfrom
jackshirazi merged 9 commits intoelastic:mainfrom
Conversation
|
💚 CLA has been signed |
github-actions
bot
added
agent-java
community
|
👋 @Cortana7 Thanks a lot for your contribution! It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it. Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it. |
JonasKunz
reviewed
Jan 16, 2024
Contributor
JonasKunz
left a comment
JonasKunz
left a comment
There was a problem hiding this comment.
First of all great work! And sorry for taking this long to review your PR. My only remarks are just two small doc changes.
You'll also need to run the ConfigurationExporterTest locally and commit the changed generated documentation files.
...t-tracer/src/main/java/co/elastic/apm/agent/tracer/configuration/MessagingConfiguration.java
Show resolved
Hide resolved
...t-tracer/src/main/java/co/elastic/apm/agent/tracer/configuration/MessagingConfiguration.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jonas Kunz <Jonas.Kunz@gmx.net>
Co-authored-by: Jonas Kunz <Jonas.Kunz@gmx.net>
JonasKunz
approved these changes
Jan 17, 2024
docs/configuration.asciidoc
Outdated
|
|
||
| A list of instrumentations which should be selectively enabled. | ||
| Valid options are `annotations`, `annotations-capture-span`, `annotations-capture-transaction`, `annotations-traced`, `apache-commons-exec`, `apache-httpclient`, `asynchttpclient`, `aws-lambda`, `aws-sdk`, `cassandra`, `concurrent`, `dubbo`, `elasticsearch-restclient`, `exception-handler`, `executor`, `executor-collection`, `experimental`, `finagle-httpclient`, `fork-join`, `grails`, `grpc`, `hibernate-search`, `http-client`, `jakarta-websocket`, `java-ldap`, `javalin`, `javax-websocket`, `jax-rs`, `jax-ws`, `jdbc`, `jdk-httpclient`, `jdk-httpserver`, `jedis`, `jms`, `jsf`, `kafka`, `lettuce`, `log-correlation`, `log-error`, `log-reformatting`, `logging`, `micrometer`, `mongodb`, `mongodb-client`, `okhttp`, `opentelemetry`, `opentelemetry-annotations`, `opentelemetry-metrics`, `opentracing`, `process`, `public-api`, `quartz`, `rabbitmq`, `reactor`, `redis`, `redisson`, `render`, `scala-future`, `scheduled`, `servlet-api`, `servlet-api-async`, `servlet-api-dispatch`, `servlet-input-stream`, `servlet-service-name`, `servlet-version`, `sparkjava`, `spring-amqp`, `spring-mvc`, `spring-resttemplate`, `spring-service-name`, `spring-view-render`, `spring-webclient`, `spring-webflux`, `ssl-context`, `struts`, `timer-task`, `urlconnection`, `vertx`, `vertx-web`, `vertx-webclient`, `websocket`. | ||
| Valid options are `annotations`, `annotations-capture-span`, `annotations-capture-transaction`, `annotations-traced`, `apache-commons-exec`, `apache-httpclient`, `asynchttpclient`, `aws-lambda`, `aws-sdk`, `cassandra`, `concurrent`, `dubbo`, `elasticsearch-restclient`, `exception-handler`, `executor`, `executor-collection`, `experimental`, `finagle-httpclient`, `fork-join`, `grails`, `grpc`, `hibernate-search`, `http-client`, `jakarta-websocket`, `javalin`, `javax-websocket`, `jax-rs`, `jax-ws`, `jdbc`, `jdk-httpclient`, `jdk-httpserver`, `jedis`, `jms`, `jsf`, `kafka`, `lettuce`, `log-correlation`, `log-error`, `log-reformatting`, `logging`, `micrometer`, `mongodb`, `mongodb-client`, `okhttp`, `opentelemetry`, `opentelemetry-annotations`, `opentelemetry-metrics`, `opentracing`, `process`, `public-api`, `quartz`, `rabbitmq`, `reactor`, `redis`, `redisson`, `render`, `scala-future`, `scheduled`, `servlet-api`, `servlet-api-async`, `servlet-api-dispatch`, `servlet-input-stream`, `servlet-service-name`, `servlet-version`, `sparkjava`, `spring-amqp`, `spring-mvc`, `spring-resttemplate`, `spring-service-name`, `spring-view-render`, `spring-webclient`, `spring-webflux`, `ssl-context`, `struts`, `timer-task`, `urlconnection`, `vertx`, `vertx-web`, `vertx-webclient`, `websocket`. |
Contributor
There was a problem hiding this comment.
Looks like you disabled the LDAP-project locally, causing it to go missing here when generating the docs. I've regenerated docs and committed to your branch.
Contributor
|
@elasticmachine run elasticsearch-ci/docs |
|
@jackshirazi Could you review this PR please? It would help us so much if it is part of the official agent! ;-) |
jackshirazi
approved these changes
Feb 7, 2024
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the ability to change the Naming Mode for the spring-rabbit plugin. It offers 2 naming modes as a configuration option: EXCHANGE and QUEUE. EXCHANGE ist the default and does not change the plugins current behaviour. If one chooses QUEUE, then the names of the rabbit transactions contain the queue names instead of the exchange names.
See Issue #3421
Checklist