Upgrade to OpenTelemetry 1.32.0, add support for bucket boundaries metrics API#3447
Merged
SylvainJuge merged 7 commits intoelastic:mainfrom Dec 6, 2023
Merged
Upgrade to OpenTelemetry 1.32.0, add support for bucket boundaries metrics API#3447SylvainJuge merged 7 commits intoelastic:mainfrom
SylvainJuge merged 7 commits intoelastic:mainfrom
Conversation
SylvainJuge
previously approved these changes
Dec 6, 2023
...ics-sdk/src/main/java/co/elastic/apm/agent/embeddedotel/proxy/ProxyLongHistogramBuilder.java
Show resolved
Hide resolved
...csdk-plugin/src/main/java/co/elastic/apm/agent/otelmetricsdk/ElasticOtelMetricsExporter.java
Outdated
Show resolved
Hide resolved
SylvainJuge
approved these changes
Dec 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upgrades to OpenTelemetry 1.32.0. Superseeds #3433.
Looks like our unit tests are doing their job and detected a new OpenTelemetry default method for which we need to add support:
OpenTelemetry
1.32.0adds the capability to define histogram bucket boundaries via the OpenTelemetry API.Unfortunately this feature only works for exporters which rely on the default aggregation.
For our
custom_metrics_histogram_boundarieshowever we needed to provide a custom aggregation from our exporter.I've fixed this by changing the approach:
HistogramBuilderis created, we initialize it's bucket boundaries tocustom_metrics_histogram_boundariesvia the newsetExplicitBucketBoundariesAdvicemethod.Unfortunately this will not work in use-cases where we instrument the SDK instead of the API.
I would however say that this is acceptable and clarified the behaviour in the documentation.
Checklist
Added an API method or config option? Document in which version this will be introduced