Skip to content

Add support for jax-ws method annotated with @WebMethod not declared by super-interfaces#3850

Merged
JonasKunz merged 2 commits intoelastic:mainfrom
JonasKunz:jaxws-webmethod-name-fix
Nov 18, 2024
Merged

Add support for jax-ws method annotated with @WebMethod not declared by super-interfaces#3850
JonasKunz merged 2 commits intoelastic:mainfrom
JonasKunz:jaxws-webmethod-name-fix

Conversation

@JonasKunz
Copy link
Contributor

@JonasKunz JonasKunz commented Oct 25, 2024

What does this PR do?

#2667 added support for capturing the JAX-WS transaction names for methods which were inherited from an @WebService interface and do not have the @WebMethod annotation. It looks like this change accidentally removed the ability of instrumenting methods with @WebMethod which do not come from an interface.

Checklist

  • This is a bugfix
@JonasKunz JonasKunz marked this pull request as ready for review October 29, 2024 14:08
@JonasKunz
Copy link
Contributor Author

User reporting this issue confirmed that this PR fixes it.

@JonasKunz JonasKunz requested a review from jackshirazi October 29, 2024 14:08
@JonasKunz
Copy link
Contributor Author

run docs-build

@JonasKunz JonasKunz merged commit 17cd358 into elastic:main Nov 18, 2024
@JonasKunz JonasKunz deleted the jaxws-webmethod-name-fix branch November 18, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants