Skip to content

Fix Manifest version reading error to support jar:file protocol#601

Merged
felixbarny merged 1 commit intoelastic:masterfrom
eyalkoren:fix-manifest-version-check
Apr 23, 2019
Merged

Fix Manifest version reading error to support jar:file protocol#601
felixbarny merged 1 commit intoelastic:masterfrom
eyalkoren:fix-manifest-version-check

Conversation

@eyalkoren
Copy link
Contributor

@eyalkoren eyalkoren commented Apr 22, 2019

Fixes #599

@eyalkoren
Copy link
Contributor Author

Jenkins run the tests

@codecov-io
Copy link

Codecov Report

Merging #601 into master will decrease coverage by 1.61%.
The diff coverage is 72.72%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #601      +/-   ##
============================================
- Coverage     63.95%   62.33%   -1.62%     
+ Complexity      148       68      -80     
============================================
  Files           188      188              
  Lines          7573     7079     -494     
  Branches        889      816      -73     
============================================
- Hits           4843     4413     -430     
+ Misses         2454     2396      -58     
+ Partials        276      270       -6
Impacted Files Coverage Δ Complexity Δ
...apm/agent/bci/bytebuddy/CustomElementMatchers.java 75.9% <72.72%> (-1.43%) 0 <0> (ø)
...apm/agent/impl/transaction/TraceContextHolder.java 50% <0%> (-12.5%) 0% <0%> (-7%)
...va/co/elastic/apm/agent/impl/transaction/Span.java 63.76% <0%> (-11.03%) 0% <0%> (-21%)
...m/agent/impl/async/SpanInScopeCallableWrapper.java 62.96% <0%> (-8.09%) 0% <0%> (ø)
...m/agent/impl/async/SpanInScopeRunnableWrapper.java 64.28% <0%> (-7.51%) 0% <0%> (ø)
.../apm/agent/concurrent/ExecutorInstrumentation.java 45.45% <0%> (-6.36%) 0% <0%> (-1%)
...lastic/apm/agent/impl/transaction/Transaction.java 71.42% <0%> (-6.25%) 0% <0%> (-11%)
...bci/methodmatching/TraceMethodInstrumentation.java 59.57% <0%> (-5.37%) 0% <0%> (ø)
...ent/jaxrs/JaxRsTransactionNameInstrumentation.java 82.75% <0%> (-2.54%) 0% <0%> (-1%)
...va/co/elastic/apm/agent/impl/ElasticApmTracer.java 82.81% <0%> (-1.92%) 0% <0%> (-19%)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f51f253...8fbc93f. Read the comment docs.

@eyalkoren eyalkoren requested a review from felixbarny April 22, 2019 15:54
@felixbarny felixbarny merged commit 831ab8f into elastic:master Apr 23, 2019
@eyalkoren eyalkoren deleted the fix-manifest-version-check branch August 21, 2019 12:34
@SylvainJuge SylvainJuge added bug Bugs and removed type: bug labels Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bugs

4 participants