Disable metrics when active=false#653
Merged
felixbarny merged 2 commits intoelastic:masterfrom Jun 11, 2019
Merged
Conversation
eyalkoren
reviewed
Jun 3, 2019
Contributor
eyalkoren
left a comment
There was a problem hiding this comment.
Great. Two comments:
- When
active=falseis used on startup, users may expect no communication is attempted with the server, so check also before doing the health check. - Add a test to this disablement
Codecov Report
@@ Coverage Diff @@
## master #653 +/- ##
============================================
- Coverage 64.77% 62.24% -2.53%
Complexity 68 68
============================================
Files 195 199 +4
Lines 8088 7782 -306
Branches 1025 959 -66
============================================
- Hits 5239 4844 -395
- Misses 2547 2640 +93
+ Partials 302 298 -4
Continue to review full report at Codecov.
|
Member
Author
|
I'm not really sure how to properly test that tbh. Not sure if the effort is worth it, especially as it's not a really critical component. |
eyalkoren
approved these changes
Jun 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.