Skip to content

feat: add support for tedious v17#3901

Merged
david-luna merged 7 commits intomainfrom
dluna/feat-support-tedious-17
Mar 7, 2024
Merged

feat: add support for tedious v17#3901
david-luna merged 7 commits intomainfrom
dluna/feat-support-tedious-17

Conversation

@david-luna
Copy link
Member

v17 release does not have major changes but just drops node versions support.

Checklist

  • Implement code
  • Add tests
  • Update TypeScript typings
  • Update documentation
  • Add CHANGELOG.asciidoc entry
  • Commit message follows commit guidelines
david-luna and others added 2 commits March 5, 2024 18:01
Copy link
Member

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think also want this change:

diff --git a/test/instrumentation/modules/tedious.test.js b/test/instrumentation/modules/tedious.test.js
index 085e0dca..5a342339 100644
--- a/test/instrumentation/modules/tedious.test.js
+++ b/test/instrumentation/modules/tedious.test.js
@@ -24,6 +24,7 @@ const tediousVer =
   require('../../../node_modules/tedious/package.json').version;
 const semver = require('semver');
 if (
+  (semver.gte(tediousVer, '17.0.0') && semver.lt(process.version, '18.0.0')) ||
   (semver.gte(tediousVer, '16.0.0') && semver.lt(process.version, '16.0.0')) ||
   (semver.gte(tediousVer, '15.0.0') && semver.lt(process.version, '14.0.0')) ||
   (semver.gte(tediousVer, '12.0.0') && semver.lt(process.version, '12.3.0')) ||

or similar. However, tedious@17.0.0 hasn't yet made any changes that actually break on node v16.

@david-luna david-luna requested a review from trentm March 6, 2024 09:12
@trentm
Copy link
Member

trentm commented Mar 6, 2024

@david-luna Did you see this comment? #3901 (review)

@david-luna
Copy link
Member Author

@david-luna Did you see this comment? #3901 (review)

sorry no, I was distracted the the mongodb issue in OTel. Your propose change makes sense, I'm going to apply it now.
Thanks!

@trentm trentm mentioned this pull request Mar 7, 2024
@david-luna david-luna merged commit d4daa4d into main Mar 7, 2024
@david-luna david-luna deleted the dluna/feat-support-tedious-17 branch March 7, 2024 19:59
PeterEinberger pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
Co-authored-by: Trent Mick <trent.mick@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants