Add ability to override default serialization#2018
Merged
xrmx merged 2 commits intoelastic:mainfrom Mar 29, 2024
Merged
Conversation
Add an alternative json serialization and deserialization implementation using simplejson configured to be JSON compliant by converting floats like nan, +inf and -inf to null . The idea is to permit users to use a different serialization if they need a different behaviour. Refs elastic#1886
xrmx
force-pushed
the
serialize-nan-as-null
branch
from
b0a4d51 to
1cc69a4
Compare
We get a string from config so need to import it.
xrmx
force-pushed
the
serialize-nan-as-null
branch
from
1cc69a4 to
2c3bd1a
Compare
basepi
approved these changes
Mar 29, 2024
xrmx
added a commit
to xrmx/apm-agent-python
that referenced
this pull request
Apr 3, 2024
* utils: add simplejson based JSON handling Add an alternative json serialization and deserialization implementation using simplejson configured to be JSON compliant by converting floats like nan, +inf and -inf to null . The idea is to permit users to use a different serialization if they need a different behaviour. Refs elastic#1886 * client: fix overriding of transport json serializer We get a string from config so need to import it.
xrmx
added a commit
that referenced
this pull request
Apr 4, 2024
* utils: add simplejson based JSON handling Add an alternative json serialization and deserialization implementation using simplejson configured to be JSON compliant by converting floats like nan, +inf and -inf to null . The idea is to permit users to use a different serialization if they need a different behaviour. Refs #1886 * client: fix overriding of transport json serializer We get a string from config so need to import it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
This PR introduces a new JSON serialization using simplejson that does a stricter serialization encoding floats like nan, +inf and -inf to null.
Then it makes the json serialization configurable from outside.
Related issues
Refs #1886