#2114 repeating query in django view#2158
Merged
xrmx merged 8 commits intoelastic:mainfrom Jul 10, 2025
Merged
Conversation
|
💚 CLA has been signed |
Contributor
Author
Member
|
cla/check |
xrmx
reviewed
Dec 24, 2024
Member
xrmx
left a comment
There was a problem hiding this comment.
I think we shouldn't poke much with Django internals, also we should not assume django is installed
Contributor
|
@xrmx can you proceed reviewing this PR ? |
Member
|
@pawelusermoc @Pokapiec pushed another commit to cleanup, does it work for you? |
xrmx
reviewed
Jul 7, 2025
xrmx
approved these changes
Jul 7, 2025
trentm
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
In this PR i add another condition to
elifstatement inutils.encoding.transformfunction to handle displaying representation of django QuerySet object in custom way. We need to do it because if we try to executereprfunction on unexecutedQuerySetwhich causes Timeout on database, it will execute byutils.encoding.transformfunction.I also added a simple test simulating database Timeout.
Related issues
Closes #2114