Skip to content

Update filter and documentation to catch *auth*#1266

Merged
jaggederest merged 3 commits intomainfrom
sanitize_using_auth
May 19, 2022
Merged

Update filter and documentation to catch *auth*#1266
jaggederest merged 3 commits intomainfrom
sanitize_using_auth

Conversation

@jaggederest
Copy link
Contributor

@jaggederest jaggederest commented May 18, 2022 •
edited
Loading

What does this pull request do?

Sanitize anything containing the word 'auth', instead of just the complete string 'authorization'

Why is it important?

Some applications may use less than the full word authorization to transmit sensitive data that should be filtered.

Checklist

  • I have signed the Contributor License Agreement.
  • My code follows the style guidelines of this project (See .rubocop.yml)
  • I have rebased my changes on top of the latest main branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Related issues

closes #1210
@jaggederest jaggederest requested a review from estolfo May 18, 2022 11:46
@jaggederest jaggederest self-assigned this May 18, 2022
@ghost
Copy link

ghost commented May 18, 2022 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-19T04:48:57.413+0000

  • Duration: 27 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 44189
Skipped 80
Total 44269

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)
@ghost
Copy link

ghost commented May 18, 2022 •
edited by ghost
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 99.2% (124/125) 👍
Classes 99.2% (124/125) 👍
Lines 59.456% (2490/4188) 👎 -0.191
Conditionals 100.0% (0/0) 💚
@jaggederest jaggederest added this to the agent-ruby-4.6.0 milestone May 19, 2022
@jaggederest jaggederest merged commit a84bbf3 into main May 19, 2022
@jaggederest jaggederest deleted the sanitize_using_auth branch May 19, 2022 11:33
estolfo pushed a commit that referenced this pull request Mar 2, 2023
@jaggederest @estolfo
Update filter and documentation to catch *auth* (#1266)
ad50621 
* Update filter and documentation to catch *auth*

* Update changelog for #1266

* Add test for new filtering for *auth* fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-ruby

2 participants

@jaggederest @estolfo