Query apm server for version and details about supported features#1278
Merged
jaggederest merged 3 commits intomainfrom Jun 3, 2022
Merged
Conversation
🌐 Coverage report
|
estolfo
approved these changes
Jun 3, 2022
Contributor
estolfo
left a comment
There was a problem hiding this comment.
Looks good!
We should think about whether we want to get the version lazily or explicitly at agent start.
Contributor
|
And just a reminder to put this into non-Draft mode to signal that your work is complete on it. |
Member
Ideally, querying the version should not block both the application startup and the agent startup. In other words, it's fine if the agent starts creating transactions and we only know about the server version some time later. |
estolfo
pushed a commit
that referenced
this pull request
Mar 2, 2023
) * Initial pass at server version checking * Testing server version checking * Update changelog for #1278
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
This adds a
versionmethod to the Config class, which internally checks the server for the value of it's version in the configuration data returned from the root urlWhy is it important?
This will be used to gate some features based on server version, most directly elastic/apm#545
Checklist
.rubocop.yml)Related issues
Closes #1274