Skip to content

Use hostname as the default Kubernetes pod name#1314

Merged
estolfo merged 2 commits intoelastic:mainfrom
estolfo:pod-name-hostname
Oct 14, 2022
Merged

Use hostname as the default Kubernetes pod name#1314
estolfo merged 2 commits intoelastic:mainfrom
estolfo:pod-name-hostname

Conversation

@estolfo
Copy link
Contributor

@estolfo estolfo commented Oct 6, 2022

Use the hostname as the Kubernetes pod name in the Container Info metadata if the pod id is parsed from /proc/self/cgroup.
This will help solve part of #1292, which is partly due to a server issue and partly due to this missing usage of the hostname as the default pod name in the Ruby agent.

@ghost
Copy link

ghost commented Oct 6, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-14T13:42:54.363+0000

  • Duration: 29 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 42263
Skipped 75
Total 42338

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@ghost
Copy link

ghost commented Oct 6, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 99.231% (129/130) 👎 -0.006
Classes 99.231% (129/130) 👎 -0.006
Lines 59.515% (2555/4293) 👍 0.513
Conditionals 100.0% (0/0) 💚
@miltonhultgren
Copy link

Thanks for fixing this! I'm not sure if my review means anything here since I don't really understand the details of Ruby or APM Agents.

Copy link
Member

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with the caveat that my Ruby is ... poor :)

@estolfo estolfo merged commit 26e0624 into elastic:main Oct 14, 2022
estolfo added a commit that referenced this pull request Mar 2, 2023
* Set Kubernetes pod name to hostname if pod id is parsed from cgroup

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants