Use hostname as the default Kubernetes pod name#1314
Merged
estolfo merged 2 commits intoelastic:mainfrom Oct 14, 2022
Merged
Conversation
🌐 Coverage report
|
f12beb8 to
3c915b1
Compare
|
Thanks for fixing this! I'm not sure if my review means anything here since I don't really understand the details of Ruby or APM Agents. |
trentm
approved these changes
Oct 14, 2022
Member
trentm
left a comment
There was a problem hiding this comment.
LGTM (with the caveat that my Ruby is ... poor :)
estolfo
added a commit
that referenced
this pull request
Mar 2, 2023
* Set Kubernetes pod name to hostname if pod id is parsed from cgroup * Update changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the hostname as the Kubernetes pod name in the Container Info metadata if the pod id is parsed from
/proc/self/cgroup.This will help solve part of #1292, which is partly due to a server issue and partly due to this missing usage of the hostname as the default pod name in the Ruby agent.