Skip to content

Set transaction sample rate to 0 when it's unsampled#1339

Merged
estolfo merged 2 commits intoelastic:mainfrom
estolfo:sampled
Jan 5, 2023
Merged

Set transaction sample rate to 0 when it's unsampled#1339
estolfo merged 2 commits intoelastic:mainfrom
estolfo:sampled

Conversation

@estolfo
Copy link
Contributor

@estolfo estolfo commented Jan 5, 2023

resolves #1338
@estolfo estolfo requested a review from simitt January 5, 2023 11:11
@ghost
Copy link

ghost commented Jan 5, 2023 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-05T11:32:47.068+0000

  • Duration: 36 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 44100
Skipped 79
Total 44179

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)
@ghost
Copy link

ghost commented Jan 5, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 99.231% (129/130) 👍
Classes 99.231% (129/130) 👍
Lines 59.609% (2562/4298) 👍 0.07
Conditionals 100.0% (0/0) 💚
@estolfo estolfo merged commit c09ba9f into elastic:main Jan 5, 2023
estolfo added a commit that referenced this pull request Mar 2, 2023
@estolfo
Set transaction sample rate to 0 when it's unsampled (#1339)
03e877d 
* Set transaction sample rate to 0 when it's unsampled

* Use eq instead of be in test for Float because of jruby
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-ruby

2 participants

@estolfo @simitt