changes/fixes to metadata.cloud.* fields collected for GCP#1415
Merged
estolfo merged 3 commits intoelastic:mainfrom Sep 18, 2023
Merged
changes/fixes to metadata.cloud.* fields collected for GCP#1415estolfo merged 3 commits intoelastic:mainfrom
estolfo merged 3 commits intoelastic:mainfrom
Conversation
- cloud.instance.id must be a string - change cloud.project.id to be the 'projectId' (per spec change) - drop cloud.project.name - fix cloud.machine.type Closes: elastic#1414
estolfo
requested changes
Sep 11, 2023
Contributor
estolfo
left a comment
estolfo
left a comment
There was a problem hiding this comment.
Thanks for doing this for the Ruby agent!
Co-authored-by: Emily S <emily.s@elastic.co>
Contributor
|
@trentm can you rebase against main? I've just merged in a fix for the test failure on ruby 2.4. |
Member
Author
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1414