Fix ActionDispatchSpy#render_exception for Rails 7.1#1423
Merged
picandocodigo merged 1 commit intoelastic:mainfrom Nov 24, 2023
Merged
Conversation
|
We're experiencing this issue as well, in the form of |
picandocodigo
approved these changes
Nov 14, 2023
In Rails 7.1 `render_exception` was changed to take an ActionDispatch::ExceptionWrapper instead of an Exception. I've added support for the new way while keeping support for pre 7.1.
picandocodigo
force-pushed
the
fix_action_dispatch_spy_render_exception
branch
from
4693a37 to
53851c3
Compare
Member
|
@elasticmachine run elasticsearch-ci/docs |
|
+1 for releasing this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Rails 7.1
render_exceptionwas changed to take an ActionDispatch::ExceptionWrapper instead of an Exception. I've added support for the new way while keeping support for pre 7.1.