Add test for capture_headers in context_builder#1449
Conversation
|
💚 CLA has been signed |
Yes, yes I have. |
4fb1308 to
098273e
Compare
|
Hi @mheiligers-godaddy thanks a lot for opening this PR! Are you sure you're signing the CLA with the same email address you use for this GitHub account? |
Yes, but I got an email from @gtback yesterday afternoon saying the system had been updated (I didn't realize there was an additional step) so the check should pass now. Separately, I see there's a failing spec on JRuby 9.2-13 with Rails 5.2, but it seems unrelated to my change, though I admit I haven't looked into it further than the stack trace in the action output. |
|
run docs-build |
|
Could we have a release with this bug fix? that would be very welcome, as our other alternative is to downgrade to 4.3 due to dependency to other gems. @estolfo |
|
Hi @sjohn-godaddy, sure, we can do a release soon. Thanks for your patience! |
|
@sjohn-godaddy @mheiligers-godaddy v4.7.3 was released with this fix. |
What does this pull request do?
PR#1405 introduced a bug where if
capture_headersisfalse, theContextBuilderwill raise "undefined method `has_key?' for nil:NilClass"Checklist
.rubocop.yml)- [ ] I have made corresponding changes to the documentation- [ ] I have updated supported-technologies.asciidoc- [ ] Added an API method or config option? Document in which version this will be introducedRelated issues