Skip to content

TBS: change default disk usage threshold to 0.8#15524

Merged
carsonip merged 4 commits intoelastic:mainfrom
carsonip:disk-usage-threshold-0.8
Feb 3, 2025
Merged

TBS: change default disk usage threshold to 0.8#15524
carsonip merged 4 commits intoelastic:mainfrom
carsonip:disk-usage-threshold-0.8

Conversation

@carsonip
Copy link
Member

@carsonip carsonip commented Feb 3, 2025 •
edited
Loading

Motivation/summary

Change TBS default usage threshold to 0.8 for a lower risk. Change log to be slightly more readable.

With this change, the log looks like

setting disk usage threshold to 80% of total disk space of 912.7gb

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

see #15467 (comment)

Related issues

Changing the default set in #15467
Part of #14933
@mergify
Copy link
Contributor

mergify bot commented Feb 3, 2025

This pull request does not have a backport label. Could you fix it @carsonip? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-9./d is the label to automatically backport to the 9./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.
@carsonip carsonip marked this pull request as ready for review February 3, 2025 13:51
@carsonip carsonip requested a review from a team as a code owner February 3, 2025 13:51
@carsonip carsonip requested a review from simitt February 3, 2025 14:34
@carsonip carsonip added the backport-9.0 Automated backport to the 9.0 branch label Feb 3, 2025
@carsonip carsonip enabled auto-merge (squash) February 3, 2025 14:39
@carsonip carsonip merged commit 9ccfae6 into elastic:main Feb 3, 2025
15 of 16 checks passed
mergify bot pushed a commit that referenced this pull request Feb 3, 2025
@carsonip @mergify
TBS: change default disk usage threshold to 0.8 (#15524)
495d16a 
Change TBS default usage threshold to 0.8 for a lower risk. Change log to be slightly more readable.

(cherry picked from commit 9ccfae6)

# Conflicts:
#	changelogs/9.0.asciidoc
@mergify mergify bot mentioned this pull request Feb 3, 2025
Merged
2 tasks
mergify bot added a commit that referenced this pull request Feb 3, 2025
@mergify @carsonip
[9.0] TBS: change default disk usage threshold to 0.8 (backport #15524)…
fadcc78 
… (#15525)

* TBS: change default disk usage threshold to 0.8 (#15524)

Change TBS default usage threshold to 0.8 for a lower risk. Change log to be slightly more readable.

(cherry picked from commit 9ccfae6)

# Conflicts:
#	changelogs/9.0.asciidoc

* Fix conflict

---------

Co-authored-by: Carson Ip <carsonip@users.noreply.github.com>
Co-authored-by: Carson Ip <carson.ip@elastic.co>
@carsonip carsonip mentioned this pull request Feb 5, 2025
Closed
7 tasks
@inge4pres inge4pres mentioned this pull request Feb 5, 2025
Closed
9 tasks
@carsonip carsonip mentioned this pull request Feb 11, 2025
Merged
2 tasks
@rubvs rubvs mentioned this pull request Jun 17, 2025
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-9.0 Automated backport to the 9.0 branch

3 participants

@carsonip @simitt @ericywl