Exclude HTTP/2 pseudo-headers from sanitization#575
Merged
Conversation
This is to avoid conflict between the ':authority' HTTP/2 pseudo-header and the addition of "*auth*" to the `sanitize_field_names` default patterns.
14 tasks
💚 Build Succeeded
Expand to view the summary
Build stats
|
axw
approved these changes
Dec 7, 2021
Member
axw
left a comment
axw
left a comment
There was a problem hiding this comment.
LGTM. If we want to capture these pseudo-headers at all, I think having a hard-coded exception for them is the way to go rather than adding config (re #573 (comment))
SylvainJuge
approved these changes
Dec 7, 2021
felixbarny
approved these changes
Dec 7, 2021
astorm
approved these changes
Dec 9, 2021
stuartnelson3
added a commit
to stuartnelson3/apm-agent-go
that referenced
this pull request
Mar 23, 2022
as discussed in elastic/apm#575
stuartnelson3
added a commit
to elastic/apm-agent-go
that referenced
this pull request
Mar 23, 2022
* sanitize *auth* instead of authorization closes #1166 * add exception for http2 :authority pseudo-header as discussed in elastic/apm#575
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This separates out the HTTP/2 pseudo-header discussion on #573. See some earlier discussion on options there.)
This is to avoid conflict between the ':authority' HTTP/2 pseudo-header
and the addition of
*auth*to thesanitize_field_namesdefault patterns in #573.The Node.js HTTP/2 core lib includes the HTTP/2 pseudo-headers in
$requestObject.headersand$responseObject.headers, so its normal capturing of headers includes them. Are other agents that have HTTP/2 support the same or different?This is a small enhancement
CODEOWNERS)