[feat:filebeat/input/redis/slowlog] Add client address and name to submitted slowlogs

[jdheyburn]

• Enhancement

Proposed commit message

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

No disruption expected

Author's Checklist

• [ ]

How to test this PR locally

Related issues

• Closes [filebeat/input/redis/slowlog] Add client IP and name to documents #40973

Use cases

Identifying which clients are causing the slow logs.

Screenshots

Logs

[mergify]

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @jdheyburn? 🙏.
For such, you'll need to label your PR with:

• The upcoming major version of the Elastic Stack
• The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

[mergify]

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

[elasticmachine]

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

[pierrehilbert]

@lalit-satapathy could we have someone from your team to review here please?

[lalit-satapathy]

@lalit-satapathy could we have someone from your team to review here please?

@devamanv, Could you take a look?

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b jdheyburn/filebeat/input/redis/add-client-info upstream/jdheyburn/filebeat/input/redis/add-client-info
git merge upstream/main
git push upstream jdheyburn/filebeat/input/redis/add-client-info

[jdheyburn]

@lalit-satapathy @devamanv Is it possible for a review? All the checks are green now.

[faec]

Approving code for data plane, but it should still have infraobs-integrations approval before merge

[ebeahan]

Buildkite test this

[ebeahan]

@lalit-satapathy @devamanv can you review these changes please?

@jdheyburn reached out out-of-band asking if we could do a final review to merge.

[ebeahan]

@elasticmachine run buildkite/beats

[ebeahan]

run docs-build

[pierrehilbert]

/test

[devamanv]

LGTM

[jdheyburn]

@ebeahan Can I assist in getting this PR over the line?

[rdner]

@jdheyburn looks like the Redis tests (Python files) are timing out. Have you tried to run them on your machine? There is also a merge conflict with the CHANGELOG.next.asciidoc file on the main branch.

Once the tests are passing and the conflict is resolved we can merge this PR.

[jdheyburn]

@rdner Thanks for checking on this! I've rebased and did some testing locally. It seems the Docker image being used in the integration tests doesn't support the new fields being added. I've made those fields optional in the harvester and upgraded the Dockerfile used for testing to support those fields.

In a follow up PR I could implement a matrix to check against varying Redis versions and the different fields they support. Given that Valkey has now forked Redis there are likely going to be differences in these too.

[rdner]

@elastic/obs-infraobs-integrations as maintainers of the module that consumes the Redis slowlogs, could you have a look?

[rdner]

/test

[rdner]

I noticed that the changelog entry was added to the old changelog file. We've migrated to using this tool instead https://github.com/elastic/elastic-agent-changelog-tool/blob/main/docs/usage.md

@jdheyburn could you please migrate the changelog entry. Sorry for the inconvenience.

[jdheyburn]

Thanks @rdner , I've used that tool to check in a new changelog, let me know if there's anything else I need to do from my side.

[rdner]

/test

[rdner]

@jdheyburn thank you!

Now everything looks good to me. Once the code owners approved the changes, Given the tests also passed, I'll merge this PR.

[rdner]

@devamanv could you have another look?