Skip to content

[filebeat] First unifiedlogs implementation#41791

Merged
marc-gr merged 18 commits intoelastic:mainfrom
marc-gr:feat/macos-ul
Dec 12, 2024
Merged

[filebeat] First unifiedlogs implementation#41791
marc-gr merged 18 commits intoelastic:mainfrom
marc-gr:feat/macos-ul

Conversation

@marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Nov 26, 2024 •
edited
Loading

Proposed commit message

Adds a new input to process logs from the MacOS Unified Logs system.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.
@marc-gr marc-gr added enhancement Team:Security-Windows Platform Windows Platform Team in Security Solution backport-8.x Automated backport to the 8.x branch with mergify labels Nov 26, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 26, 2024
@marc-gr marc-gr force-pushed the feat/macos-ul branch 2 times, most recently from 9bd680d to 033ceaa Compare November 26, 2024 12:50
@mergify
Copy link
Contributor

mergify bot commented Dec 3, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feat/macos-ul upstream/feat/macos-ul
git merge upstream/main
git push upstream feat/macos-ul
@cla-checker-service
Copy link

cla-checker-service bot commented Dec 5, 2024 •
edited
Loading

💚 CLA has been signed
@mergify
Copy link
Contributor

mergify bot commented Dec 5, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feat/macos-ul upstream/feat/macos-ul
git merge upstream/main
git push upstream feat/macos-ul
@marc-gr marc-gr marked this pull request as ready for review December 5, 2024 20:11
@marc-gr marc-gr requested a review from a team as a code owner December 5, 2024 20:11
@marc-gr marc-gr requested a review from AndersonQ December 5, 2024 20:11
@marc-gr marc-gr requested a review from rdner December 5, 2024 20:11
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 5, 2024

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)
rdner
rdner reviewed Dec 10, 2024
View reviewed changes
matthewscherer
matthewscherer approved these changes Dec 11, 2024
View reviewed changes
Copy link

@matthewscherer matthewscherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
x-pack/filebeat/input/unifiedlogs/input_test.go
return nil
}

func TestInput(t *testing.T) {
Copy link

@matthewscherer matthewscherer Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the tests.
@marc-gr marc-gr merged commit f9a9b32 into elastic:main Dec 12, 2024
@marc-gr marc-gr deleted the feat/macos-ul branch December 12, 2024 07:27
mergify bot pushed a commit that referenced this pull request Dec 12, 2024
@marc-gr @ricardo-estc @mergify
[filebeat] First unifiedlogs implementation (#41791)
1858c76 
* First unifiedlogs implementation

* Fix date check and accept multiple predicates

* Fix cursor and date walking

* Log stderr on error

* Add 1s tick

* Refactor to do automatic backfill

* Add docs and fix resuming from interrupted backfilling

* Fix doc config example

* Add first unit tests

* wip tests

* Add stream test

* Extract test and make input stable

* Improve docs

---------

Co-authored-by: r-ung <ricardo.ungureanu@elastic.co>
(cherry picked from commit f9a9b32)
@mergify mergify bot mentioned this pull request Dec 12, 2024
Merged
6 tasks
marc-gr added a commit that referenced this pull request Dec 12, 2024
@mergify @marc-gr
[filebeat] First unifiedlogs implementation (#41791) (#42005)
63df576 
* First unifiedlogs implementation

* Fix date check and accept multiple predicates

* Fix cursor and date walking

* Log stderr on error

* Add 1s tick

* Refactor to do automatic backfill

* Add docs and fix resuming from interrupted backfilling

* Fix doc config example

* Add first unit tests

* wip tests

* Add stream test

* Extract test and make input stable

* Improve docs

---------

Co-authored-by: r-ung <ricardo.ungureanu@elastic.co>
(cherry picked from commit f9a9b32)

Co-authored-by: Marc Guasch <marc-gr@users.noreply.github.com>
michalpristas pushed a commit to michalpristas/beats that referenced this pull request Dec 13, 2024
@marc-gr @ricardo-estc @michalpristas
[filebeat] First unifiedlogs implementation (elastic#41791)
5b66f31 
* First unifiedlogs implementation

* Fix date check and accept multiple predicates

* Fix cursor and date walking

* Log stderr on error

* Add 1s tick

* Refactor to do automatic backfill

* Add docs and fix resuming from interrupted backfilling

* Fix doc config example

* Add first unit tests

* wip tests

* Add stream test

* Extract test and make input stable

* Improve docs

---------

Co-authored-by: r-ung <ricardo.ungureanu@elastic.co>
@marc-gr marc-gr mentioned this pull request Feb 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.x Automated backport to the 8.x branch with mergify enhancement Team:Security-Windows Platform Windows Platform Team in Security Solution

5 participants

@marc-gr @elasticmachine @rdner @matthewscherer @ricardo-estc