Skip to content

[metricbeat] Add a new 'match_by_parent_instance' option to 'perfmon' module#43002

Merged
marc-gr merged 6 commits intoelastic:mainfrom
marc-gr:feat/mb-group-opts
Mar 6, 2025
Merged

[metricbeat] Add a new 'match_by_parent_instance' option to 'perfmon' module#43002
marc-gr merged 6 commits intoelastic:mainfrom
marc-gr:feat/mb-group-opts

Conversation

@marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Mar 4, 2025

Proposed commit message

Add a new 'match_by_parent_instance' option to 'perfmon' module. This will let users prevent instance names from dropping instance numbers.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.
@marc-gr marc-gr added enhancement backport-8.x Automated backport to the 8.x branch with mergify backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches labels Mar 4, 2025
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 4, 2025
@marc-gr marc-gr force-pushed the feat/mb-group-opts branch from be578af to 87a145b Compare March 4, 2025 15:23
@marc-gr marc-gr marked this pull request as ready for review March 4, 2025 15:23
@marc-gr marc-gr requested a review from a team as a code owner March 4, 2025 15:23
@mergify mergify bot assigned marc-gr Mar 4, 2025
@nfritts nfritts mentioned this pull request Mar 4, 2025
Open
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Mar 4, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 4, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 4, 2025

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)
@pierrehilbert pierrehilbert requested a review from leehinman March 4, 2025 16:20
leehinman
leehinman approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the linter is happy.
AndersonQ
AndersonQ approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@AndersonQ AndersonQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about this part of the code, but looks good
@marc-gr marc-gr enabled auto-merge (squash) March 5, 2025 08:47
@marc-gr marc-gr disabled auto-merge March 5, 2025 08:55
@marc-gr marc-gr merged commit 180bd96 into elastic:main Mar 6, 2025
34 checks passed
@marc-gr marc-gr deleted the feat/mb-group-opts branch March 6, 2025 10:01
mergify bot pushed a commit that referenced this pull request Mar 6, 2025
@marc-gr @mergify
[metricbeat] Add a new 'match_by_parent_instance' option to 'perfmon'…
21f6424 
… module (#43002)

* Add a new 'match_by_parent_instance' option to 'perfmon' module

* Add type assertion check

(cherry picked from commit 180bd96)
mergify bot pushed a commit that referenced this pull request Mar 6, 2025
@marc-gr @mergify
[metricbeat] Add a new 'match_by_parent_instance' option to 'perfmon'…
07341d7 
… module (#43002)

* Add a new 'match_by_parent_instance' option to 'perfmon' module

* Add type assertion check

(cherry picked from commit 180bd96)
This was referenced Mar 6, 2025
Merged
Merged
marc-gr added a commit that referenced this pull request Mar 6, 2025
@mergify @marc-gr
[metricbeat] Add a new 'match_by_parent_instance' option to 'perfmon'…
cadba94 
… module (#43002) (#43069)

* Add a new 'match_by_parent_instance' option to 'perfmon' module

* Add type assertion check

(cherry picked from commit 180bd96)

Co-authored-by: Marc Guasch <marc-gr@users.noreply.github.com>
marc-gr added a commit that referenced this pull request Mar 6, 2025
@mergify @marc-gr
[metricbeat] Add a new 'match_by_parent_instance' option to 'perfmon'…
726740a 
… module (#43002) (#43070)

* Add a new 'match_by_parent_instance' option to 'perfmon' module

* Add type assertion check

(cherry picked from commit 180bd96)

Co-authored-by: Marc Guasch <marc-gr@users.noreply.github.com>
v1v added a commit to v1v/beats that referenced this pull request Mar 6, 2025
@v1v
Merge remote-tracking branch 'upstream/main' into feature/addminssing…
b11820c 
…-packaging-steps

* upstream/main:
  filebeat: make deep copy before notifying of config change (elastic#42992)
  [metricbeat] Add a new 'match_by_parent_instance' option to 'perfmon' module (elastic#43002)
  Don't package arm64 on amd64 workers (elastic#43026)
  [REVERT] Update Stack Monitoring data stream to 9 (elastic#43052)
  FIPS Build (elastic#42402)
  refactor: drop custom fsync implementation (elastic#42066)
  Update CHANGELOG.asciidoc
  docs: Prepare Changelog for 8.17.3 (elastic#42980) (elastic#43029)
  Fix boolean key in security pipelines and sync pipelines with integration. (elastic#43027)
  Skip test case for sequoia (elastic#42996)
  [main](backport elastic#42976) docs: Prepare Changelog for 8.16.5 (elastic#43005)
  x-pack/filebeat/input/entityanalytics/provider/activedirectory: do not consider computers to be users (elastic#42796)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.x Automated backport to the 8.x branch with mergify backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches enhancement Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

6 participants

@marc-gr @elasticmachine @AndersonQ @leehinman @VihasMakwana @pierrehilbert