Skip to content

Allow faccessat(2) as well as faccessat2(2)#43322

Merged
haesbaert merged 3 commits intomainfrom
faccessat
Mar 20, 2025
Merged

Allow faccessat(2) as well as faccessat2(2)#43322
haesbaert merged 3 commits intomainfrom
faccessat

Conversation

@haesbaert
Copy link
Contributor

@haesbaert haesbaert commented Mar 18, 2025

Proposed commit message

There's an older faccessat(2) that is used by older glibc, particularly the one in ubuntu 20.04.

Any cgo program (like any processor using quark) might end up needing that.

Checklist

Add a checklist of things that are required to be reviewed in order to have the PR approved

List here all the items you have verified BEFORE sending this PR. Please DO NOT remove any item, striking through those that do not apply. (Just in case, strikethrough uses two tildes. Scratch this.)

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Related to an internal issue raised.

Use cases

when using kernel_tracing as the backend add_session_metadata_processor or the new system/process module backend, it ends up calling faccessat(3) which might be faccessat2(2) or faccessat(2), depending on the glibc version.
Allow both otherwise kernel_tracing will always fail.

There's an older faccessat(2) that is used by older glibc, particularly the one
in ubuntu 20.04.

Any cgo program (like any processor using quark) might end up needing that.
@haesbaert haesbaert added bug backport-8.x Automated backport to the 8.x branch with mergify labels Mar 18, 2025
@haesbaert haesbaert requested a review from a team as a code owner March 18, 2025 11:06
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 18, 2025
@haesbaert haesbaert added the Team:Security-Linux Platform Linux Platform Team in Security Solution label Mar 18, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 18, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Mar 18, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@haesbaert haesbaert enabled auto-merge (squash) March 20, 2025 09:09
@haesbaert haesbaert merged commit 73353a8 into main Mar 20, 2025
148 checks passed
@haesbaert haesbaert deleted the faccessat branch March 20, 2025 10:45
mergify bot pushed a commit that referenced this pull request Mar 20, 2025
There's an older faccessat(2) that is used by older glibc, particularly the one
in ubuntu 20.04.

Any cgo program (like any processor using quark) might end up needing that.

(cherry picked from commit 73353a8)
@andrewkroh andrewkroh added backport-active-8 Automated backport with mergify to all the active 8.[0-9]+ branches backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches labels Mar 20, 2025
mergify bot pushed a commit that referenced this pull request Mar 20, 2025
There's an older faccessat(2) that is used by older glibc, particularly the one
in ubuntu 20.04.

Any cgo program (like any processor using quark) might end up needing that.

(cherry picked from commit 73353a8)
mergify bot pushed a commit that referenced this pull request Mar 20, 2025
There's an older faccessat(2) that is used by older glibc, particularly the one
in ubuntu 20.04.

Any cgo program (like any processor using quark) might end up needing that.

(cherry picked from commit 73353a8)
mergify bot pushed a commit that referenced this pull request Mar 20, 2025
There's an older faccessat(2) that is used by older glibc, particularly the one
in ubuntu 20.04.

Any cgo program (like any processor using quark) might end up needing that.

(cherry picked from commit 73353a8)
mergify bot pushed a commit that referenced this pull request Mar 20, 2025
There's an older faccessat(2) that is used by older glibc, particularly the one
in ubuntu 20.04.

Any cgo program (like any processor using quark) might end up needing that.

(cherry picked from commit 73353a8)
@andrewkroh
Copy link
Member

@haesbaert I assume this fix is required on a few more branches beyond 8.x such as 8.17, 8.18, 9.0 so I added some more backport labels. Please shepherd those backport PRs to ensure they get merged.

@haesbaert
Copy link
Contributor Author

@haesbaert I assume this fix is required on a few more branches beyond 8.x such as 8.17, 8.18, 9.0 so I added some more backport labels. Please shepherd those backport PRs to ensure they get merged.

will do thanks!

haesbaert added a commit that referenced this pull request Mar 20, 2025
There's an older faccessat(2) that is used by older glibc, particularly the one
in ubuntu 20.04.

Any cgo program (like any processor using quark) might end up needing that.

(cherry picked from commit 73353a8)

Co-authored-by: Christiano Haesbaert <haesbaert@elastic.co>
haesbaert added a commit that referenced this pull request Mar 20, 2025
There's an older faccessat(2) that is used by older glibc, particularly the one
in ubuntu 20.04.

Any cgo program (like any processor using quark) might end up needing that.

(cherry picked from commit 73353a8)

Co-authored-by: Christiano Haesbaert <haesbaert@elastic.co>
haesbaert added a commit that referenced this pull request Mar 20, 2025
There's an older faccessat(2) that is used by older glibc, particularly the one
in ubuntu 20.04.

Any cgo program (like any processor using quark) might end up needing that.

(cherry picked from commit 73353a8)

Co-authored-by: Christiano Haesbaert <haesbaert@elastic.co>
pierrehilbert pushed a commit that referenced this pull request Mar 21, 2025
There's an older faccessat(2) that is used by older glibc, particularly the one
in ubuntu 20.04.

Any cgo program (like any processor using quark) might end up needing that.

(cherry picked from commit 73353a8)

Co-authored-by: Christiano Haesbaert <haesbaert@elastic.co>
haesbaert added a commit that referenced this pull request Mar 21, 2025
There's an older faccessat(2) that is used by older glibc, particularly the one
in ubuntu 20.04.

Any cgo program (like any processor using quark) might end up needing that.

(cherry picked from commit 73353a8)

Co-authored-by: Christiano Haesbaert <haesbaert@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.x Automated backport to the 8.x branch with mergify backport-active-8 Automated backport with mergify to all the active 8.[0-9]+ branches backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches bug Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Security-Linux Platform Linux Platform Team in Security Solution

8 participants