[9.0](backport #41790) Concurrent fetch of azure metricdefinitions and batchApi usage#43923
Merged
MichaelKatsoulis merged 4 commits into9.0from Apr 22, 2025
Merged
[9.0](backport #41790) Concurrent fetch of azure metricdefinitions and batchApi usage#43923MichaelKatsoulis merged 4 commits into9.0from
MichaelKatsoulis merged 4 commits into9.0from
Conversation
* Use concurrency in metricsdefinition collection * Change ResourceConfigurations.Metrics to a map * Use batch API * New queryResourceClient per location * Wait for 50 reource ids before fetching the metrics * Set timegrain if is equal to ''" * Use batch API as feature * Use baseclient to tackle code duplication * Add unit tests for concurrent fetching of metric definitions * Add batch client unit tests * Add support of batch API for storage accounts * Update docs and add unit tests form storage client * Split metric names by 20 (cherry picked from commit 13f8fde) # Conflicts: # go.mod # go.sum
Contributor
Author
|
Cherry-pick of 13f8fde has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Contributor
|
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
Contributor
Author
|
This pull request is now in conflicts. Could you fix it? 🙏 |
Contributor
Author
|
This pull request has not been merged yet. Could you please review and merge it @MichaelKatsoulis? 🙏 |
MichaelKatsoulis
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes affect azure monitor and relevant metricsets. The list of metricsets affected are:
monitorcontainer_registrycontainer_instancecontainer_servicecompute_vmcompute_vm_scalesetdatabase_accountstorage_accountA new configuration parameter is introduced
enable_batch_apiof type boolean.If set to
false(default) nothing changes in the way the metrics are collected for these metricsets.If set to
true:metrics of multiple resources with one api call.
Proposed commit message
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs
This is an automatic backport of pull request #41790 done by [Mergify](https://mergify.com).