[8.18](backport #41790) Concurrent fetch of azure metricdefinitions and batchApi usage#44242
[8.18](backport #41790) Concurrent fetch of azure metricdefinitions and batchApi usage#44242
Conversation
|
Cherry-pick of 13f8fde has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
|
This pull request has not been merged yet. Could you please review and merge it @MichaelKatsoulis? 🙏 |
|
This pull request has not been merged yet. Could you please review and merge it @zmoog, @MichaelKatsoulis? 🙏 |
|
This pull request is now in conflicts. Could you fix it? 🙏 |
* Use concurrency in metricsdefinition collection * Change ResourceConfigurations.Metrics to a map * Use batch API * New queryResourceClient per location * Wait for 50 reource ids before fetching the metrics * Set timegrain if is equal to ''" * Use batch API as feature * Use baseclient to tackle code duplication * Add unit tests for concurrent fetching of metric definitions * Add batch client unit tests * Add support of batch API for storage accounts * Update docs and add unit tests form storage client * Split metric names by 20 (cherry picked from commit 13f8fde) # Conflicts: # go.mod # go.sum # metricbeat/docs/modules/azure.asciidoc
8d7173d to
2ec5f06
Compare
|
This pull request is now in conflicts. Could you fix it? 🙏 |
The changes affect azure monitor and relevant metricsets. The list of metricsets affected are:
monitorcontainer_registrycontainer_instancecontainer_servicecompute_vmcompute_vm_scalesetdatabase_accountstorage_accountA new configuration parameter is introduced
enable_batch_apiof type boolean.If set to
false(default) nothing changes in the way the metrics are collected for these metricsets.If set to
true:metrics of multiple resources with one api call.
Proposed commit message
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs
This is an automatic backport of pull request #41790 done by [Mergify](https://mergify.com).