Skip to content

[beats] add milliseconds to awscloudwatch Filebeat input #43481#44306

Merged
Kavindu-Dodan merged 10 commits intoelastic:mainfrom
sptsway:timestamp
May 20, 2025
Merged

[beats] add milliseconds to awscloudwatch Filebeat input #43481#44306
Kavindu-Dodan merged 10 commits intoelastic:mainfrom
sptsway:timestamp

Conversation

@sptsway
Copy link
Contributor

@sptsway sptsway commented May 10, 2025

Proposed commit message

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@sptsway sptsway requested a review from a team as a code owner May 10, 2025 12:48
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 10, 2025
@mergify
Copy link
Contributor

mergify bot commented May 10, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @sptsway? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.
@Kavindu-Dodan Kavindu-Dodan added the Team:obs-ds-hosted-services Label for the Observability Hosted Services team label May 12, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 12, 2025
- add milliseconds to awscloudwatch Filebeat input elastic#43481
- `time.Unix()` takes nanoseconds as second param, the PR converts milliseconds into nanoseconds to fix the issue
- elastic#43481
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Could you add a changelog entry here please? Thank you!

@sptsway
Copy link
Contributor Author

sptsway commented May 12, 2025

Thanks for the fix! Could you add a changelog entry here please? Thank you!

does it need to be in the same PR?
edit: nvm done

@kaiyan-sheng kaiyan-sheng added the backport-active-all Automated backport with mergify to all the active branches label May 12, 2025
Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
@sptsway sptsway closed this May 12, 2025
@sptsway sptsway reopened this May 12, 2025
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes looks fine. I will wait for #44306 (comment) to be addressed and then we can merge.

@kaiyan-sheng given this is a new addition, we can avoid backports. But let me know your thoughts on that.

@sptsway sptsway requested a review from Kavindu-Dodan May 13, 2025 15:35
@sptsway
Copy link
Contributor Author

sptsway commented May 13, 2025

buildkite/beatsExpected — Waiting for status to be reported

@Kavindu-Dodan has this build timedout or something? i dont see option to merge so

@Kavindu-Dodan
Copy link
Contributor

buildkite/beatsExpected — Waiting for status to be reported

@Kavindu-Dodan has this build timedout or something? i dont see option to merge so

buildkite build did not start, I have manually triggered a build based on your change. I will take care of the merge once build is green :)

@sptsway
Copy link
Contributor Author

sptsway commented May 13, 2025

buildkite/beatsExpected — Waiting for status to be reported

@Kavindu-Dodan has this build timedout or something? i dont see option to merge so

buildkite build did not start, I have manually triggered a build based on your change. I will take care of the merge once build is green :)

thanks

@Kavindu-Dodan Kavindu-Dodan added backport-8.19 Automated backport to the 8.19 branch and removed backport-active-all Automated backport with mergify to all the active branches labels May 13, 2025
@Kavindu-Dodan
Copy link
Contributor

There are some integration test failures but they are not related to this change. I will wait till the main branch get stable and rebase this PR.

@mergify
Copy link
Contributor

mergify bot commented May 14, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b timestamp upstream/timestamp
git merge upstream/main
git push upstream timestamp
@Kavindu-Dodan
Copy link
Contributor

Unfortunately, main branch builds are still failing due to integration test failure. These are tracked with,

Will track and re-trigger a build once these are fixed

@sptsway
Copy link
Contributor Author

sptsway commented May 20, 2025

hey @Kavindu-Dodan, are the tests fixed and passing now?

@kaiyan-sheng
Copy link
Contributor

/test

@Kavindu-Dodan
Copy link
Contributor

@sptsway builds are green and thank you for the contribution :) I will merge this now and it will be available with 8.19.0 release

@Kavindu-Dodan Kavindu-Dodan merged commit 425932a into elastic:main May 20, 2025
31 checks passed
mergify bot pushed a commit that referenced this pull request May 20, 2025
* [beats] add milliseconds to awscloudwatch Filebeat input #43481

- add milliseconds to awscloudwatch Filebeat input #43481
- `time.Unix()` takes nanoseconds as second param, the PR converts milliseconds into nanoseconds to fix the issue
- #43481

* Update CHANGELOG.next.asciidoc

* Update CHANGELOG.next.asciidoc

Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>

* Update CHANGELOG.next.asciidoc

resolve comments

* Update CHANGELOG.next.asciidoc

* Update CHANGELOG.next.asciidoc

* Update CHANGELOG.next.asciidoc

---------

Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
(cherry picked from commit 425932a)
Kavindu-Dodan added a commit that referenced this pull request May 20, 2025
…ebeat input #43481 (#44403)

* [beats] add milliseconds to awscloudwatch Filebeat input #43481 (#44306)

* [beats] add milliseconds to awscloudwatch Filebeat input #43481

- add milliseconds to awscloudwatch Filebeat input #43481
- `time.Unix()` takes nanoseconds as second param, the PR converts milliseconds into nanoseconds to fix the issue
- #43481

* Update CHANGELOG.next.asciidoc

* Update CHANGELOG.next.asciidoc

Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>

* Update CHANGELOG.next.asciidoc

resolve comments

* Update CHANGELOG.next.asciidoc

* Update CHANGELOG.next.asciidoc

* Update CHANGELOG.next.asciidoc

---------

Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
(cherry picked from commit 425932a)

* Update CHANGELOG.next.asciidoc

---------

Co-authored-by: Swaraj Pradhan <tts312@outlook.com>
Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
@sptsway sptsway deleted the timestamp branch May 21, 2025 12:54
@kaiyan-sheng kaiyan-sheng added the backport-9.0 Automated backport to the 9.0 branch label May 21, 2025
mergify bot pushed a commit that referenced this pull request May 21, 2025
* [beats] add milliseconds to awscloudwatch Filebeat input #43481

- add milliseconds to awscloudwatch Filebeat input #43481
- `time.Unix()` takes nanoseconds as second param, the PR converts milliseconds into nanoseconds to fix the issue
- #43481

* Update CHANGELOG.next.asciidoc

* Update CHANGELOG.next.asciidoc

Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>

* Update CHANGELOG.next.asciidoc

resolve comments

* Update CHANGELOG.next.asciidoc

* Update CHANGELOG.next.asciidoc

* Update CHANGELOG.next.asciidoc

---------

Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
(cherry picked from commit 425932a)
@Kavindu-Dodan Kavindu-Dodan removed the backport-9.0 Automated backport to the 9.0 branch label May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.19 Automated backport to the 8.19 branch Team:obs-ds-hosted-services Label for the Observability Hosted Services team

4 participants