[beats] add milliseconds to awscloudwatch Filebeat input #43481#44306
[beats] add milliseconds to awscloudwatch Filebeat input #43481#44306Kavindu-Dodan merged 10 commits intoelastic:mainfrom
Conversation
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
- add milliseconds to awscloudwatch Filebeat input elastic#43481 - `time.Unix()` takes nanoseconds as second param, the PR converts milliseconds into nanoseconds to fix the issue - elastic#43481
kaiyan-sheng
left a comment
There was a problem hiding this comment.
Thanks for the fix! Could you add a changelog entry here please? Thank you!
|
Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
There was a problem hiding this comment.
changes looks fine. I will wait for #44306 (comment) to be addressed and then we can merge.
@kaiyan-sheng given this is a new addition, we can avoid backports. But let me know your thoughts on that.
@Kavindu-Dodan has this build timedout or something? i dont see option to merge so |
buildkite build did not start, I have manually triggered a build based on your change. I will take care of the merge once build is green :) |
thanks |
|
There are some integration test failures but they are not related to this change. I will wait till the main branch get stable and rebase this PR. |
|
This pull request is now in conflicts. Could you fix it? 🙏 |
|
Unfortunately, main branch builds are still failing due to integration test failure. These are tracked with,
Will track and re-trigger a build once these are fixed |
|
hey @Kavindu-Dodan, are the tests fixed and passing now? |
|
/test |
|
@sptsway builds are green and thank you for the contribution :) I will merge this now and it will be available with 8.19.0 release |
* [beats] add milliseconds to awscloudwatch Filebeat input #43481 - add milliseconds to awscloudwatch Filebeat input #43481 - `time.Unix()` takes nanoseconds as second param, the PR converts milliseconds into nanoseconds to fix the issue - #43481 * Update CHANGELOG.next.asciidoc * Update CHANGELOG.next.asciidoc Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co> * Update CHANGELOG.next.asciidoc resolve comments * Update CHANGELOG.next.asciidoc * Update CHANGELOG.next.asciidoc * Update CHANGELOG.next.asciidoc --------- Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co> (cherry picked from commit 425932a)
…ebeat input #43481 (#44403) * [beats] add milliseconds to awscloudwatch Filebeat input #43481 (#44306) * [beats] add milliseconds to awscloudwatch Filebeat input #43481 - add milliseconds to awscloudwatch Filebeat input #43481 - `time.Unix()` takes nanoseconds as second param, the PR converts milliseconds into nanoseconds to fix the issue - #43481 * Update CHANGELOG.next.asciidoc * Update CHANGELOG.next.asciidoc Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co> * Update CHANGELOG.next.asciidoc resolve comments * Update CHANGELOG.next.asciidoc * Update CHANGELOG.next.asciidoc * Update CHANGELOG.next.asciidoc --------- Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co> (cherry picked from commit 425932a) * Update CHANGELOG.next.asciidoc --------- Co-authored-by: Swaraj Pradhan <tts312@outlook.com> Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co> Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
* [beats] add milliseconds to awscloudwatch Filebeat input #43481 - add milliseconds to awscloudwatch Filebeat input #43481 - `time.Unix()` takes nanoseconds as second param, the PR converts milliseconds into nanoseconds to fix the issue - #43481 * Update CHANGELOG.next.asciidoc * Update CHANGELOG.next.asciidoc Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co> * Update CHANGELOG.next.asciidoc resolve comments * Update CHANGELOG.next.asciidoc * Update CHANGELOG.next.asciidoc * Update CHANGELOG.next.asciidoc --------- Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co> (cherry picked from commit 425932a)
time.Unix()takes nanoseconds as second param, the PR converts milliseconds into nanoseconds to fix the issueProposed commit message
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs