[filebeat][streaming] - Fixed a websocket panic scenario which would occur after exhausting max retries#44342
Merged
ShourieG merged 7 commits intoelastic:mainfrom May 20, 2025
Conversation
ShourieG
added
Filebeat
Contributor
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
botelastic
bot
added
needs_team
ShourieG
changed the title
ShourieG
commented
May 15, 2025
ShourieG
commented
May 15, 2025
efd6
reviewed
May 15, 2025
Contributor
Author
|
@efd6, resolved all comments |
efd6
approved these changes
May 16, 2025
This was referenced May 20, 2025
6 tasks
6 tasks
ShourieG
added a commit
that referenced
this pull request
May 20, 2025
…occur after exhausting max retries (#44342) (#44390) In some scenarios the websocket response object can become nil and cause certain logging statements to cause an unexpected panic. This PR fixes once such identified scenario. (cherry picked from commit f6994c0) Co-authored-by: Shourie Ganguly <shourie.ganguly@elastic.co>
ShourieG
added a commit
that referenced
this pull request
May 20, 2025
…occur after exhausting max retries (#44342) (#44391) In some scenarios the websocket response object can become nil and cause certain logging statements to cause an unexpected panic. This PR fixes once such identified scenario. (cherry picked from commit f6994c0) Co-authored-by: Shourie Ganguly <shourie.ganguly@elastic.co>
ShourieG
added a commit
that referenced
this pull request
May 20, 2025
…occur after exhausting max retries (#44342) (#44392) In some scenarios the websocket response object can become nil and cause certain logging statements to cause an unexpected panic. This PR fixes once such identified scenario. (cherry picked from commit f6994c0) Co-authored-by: Shourie Ganguly <shourie.ganguly@elastic.co>
ShourieG
added a commit
that referenced
this pull request
May 20, 2025
…ic scenario which would occur after exhausting max retries (#44389) * [filebeat][streaming] - Fixed a websocket panic scenario which would occur after exhausting max retries (#44342) In some scenarios the websocket response object can become nil and cause certain logging statements to cause an unexpected panic. This PR fixes once such identified scenario. (cherry picked from commit f6994c0) * Update CHANGELOG.next.asciidoc --------- Co-authored-by: Shourie Ganguly <shourie.ganguly@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Proposed commit message
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
None
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs