[8.19](backport #41508) [Heartbeat] Adds maintenance windows !!#44689
Merged
emilioalvap merged 9 commits into8.19from Jun 19, 2025
Merged
[8.19](backport #41508) [Heartbeat] Adds maintenance windows !!#44689emilioalvap merged 9 commits into8.19from
emilioalvap merged 9 commits into8.19from
Conversation
* Add maint windows * Initial maint win MVP * added maintenance windows * destroy cluster * format * revert file * revert file * added lib * revert * space * add license * update * update * fix tests * lint * skip run once * Fix linting * Remove unused fields * Make update * add more test cases * utc * lint * handle errors * bit of refactor * emilio suggestion * More PR feedback * lint * add validation for map * nil condition * set count to default * add validation for only daily * add dt start validation * revrt * revrt * revert * revert * format * PR feedback * add docs * Update heartbeat/monitors/maintwin/maintwin.go Co-authored-by: Emilio Alvarez Piñeiro <95703246+emilioalvap@users.noreply.github.com> * Update heartbeat/monitors/maintwin/maintwin.go Co-authored-by: Emilio Alvarez Piñeiro <95703246+emilioalvap@users.noreply.github.com> * fomat * change log --------- Co-authored-by: Andrew Cholakian <andrewvc@elastic.co> Co-authored-by: emilioalvap <emilio.alvarezpineiro@elastic.co> Co-authored-by: Emilio Alvarez Piñeiro <95703246+emilioalvap@users.noreply.github.com> (cherry picked from commit f6fb08d) # Conflicts: # go.mod # go.sum
Contributor
Author
|
Cherry-pick of f6fb08d has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Contributor
|
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
Contributor
Author
|
This pull request has not been merged yet. Could you please review and merge it @shahzad31? 🙏 |
Contributor
Author
|
This pull request has not been merged yet. Could you please review and merge it @shahzad31? 🙏 |
Contributor
Author
|
This pull request is now in conflicts. Could you fix it? 🙏 |
mcapell
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Added maintenance windows in heartbeat in RFC 5545 format using rrule-go library, this makes it compatible with kibana alerting maintenance windows which are using the same format https://www.elastic.co/guide/en/kibana/current/maintenance-windows.html
This will allow us to simple pass values from alerting maintenance windows where those are applicable to synthetics monitors as heartbeat configs
example being
heartbeat.monitors:
Limitations
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs
This is an automatic backport of pull request #41508 done by [Mergify](https://mergify.com).