[8.19](backport #44697) Remove ID from list when Filestream inputs fail to be created#44738
Merged
[8.19](backport #44697) Remove ID from list when Filestream inputs fail to be created#44738
Conversation
Filestream was not removing the ID from inputs that failed to start, that made re-starting the same input with a valid configuration to fail with a duplicated ID error. This affects any configuration mode that can be reloaded, Elastic-Agent being the main use case. This commit fixes it by removing the ID from a failed input. --------- Co-authored-by: Anderson Queiroz <me@andersonq.me> (cherry picked from commit 017cc4f) # Conflicts: # filebeat/input/filestream/internal/input-logfile/manager.go # filebeat/input/filestream/internal/input-logfile/manager_test.go
Contributor
Author
|
Cherry-pick of 017cc4f has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
4 tasks
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
belimawr
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Filestream was not removing the ID from inputs that failed to start, that made re-starting the same input with a valid configuration to fail with a duplicated ID error. This affects any configuration mode that can be reloaded, Elastic-Agent being the main use case.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
## Author's ChecklistHow to test this PR locally
1. Create the following files
filebeat.yml
inputs.d/filestream.yml
/tmp/flog.log
2. Build and Start Filebeat
go build . ./filebeatWait for the log error:
3. Edit
inputs.d/filestream.ymlso it is validRemove the first, invalid, path and uncomment the second one.
pathssection so it looks like this:Save the file and wait to see the ingested events in the console.
## Related issues## Use cases## Screenshots## LogsThis is an automatic backport of pull request #44697 done by Mergify.