[filebeat][ABS] - Fixed issue for "Root level readerConfig no longer respected"#44873
Merged
ShourieG merged 10 commits intoelastic:mainfrom Jun 19, 2025
Merged
[filebeat][ABS] - Fixed issue for "Root level readerConfig no longer respected"#44873ShourieG merged 10 commits intoelastic:mainfrom
ShourieG merged 10 commits intoelastic:mainfrom
Conversation
ShourieG
added
Filebeat
botelastic
bot
added
needs_team
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Contributor
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
efd6
reviewed
Jun 18, 2025
Contributor
Author
|
@efd6, have resolved all the comments |
Contributor
Author
|
/test |
efd6
reviewed
Jun 18, 2025
VihasMakwana
approved these changes
Jun 19, 2025
Contributor
Author
|
@Mergifyio backport 8.19 |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 8, 2025
…respected" (#44873) Due to how we pre-fill certain default config values, the recently added 'isConfigEmpty' check was not sufficient to differentiate between an empty and default readerConfig state. This PR overhauls the comparison, replacing the 'isConfigEmpty' with a reflect.DeepEqual against a generated default 'readerConfig' state. This approach avoids the pitfalls of the existing validation and allows both global & container level 'readerConfig' configurations. (cherry picked from commit 01adb89) # Conflicts: # x-pack/filebeat/input/azureblobstorage/input_test.go
6 tasks
ShourieG
added a commit
that referenced
this pull request
Dec 8, 2025
… readerConfig no longer respected" (#47976) * [filebeat][ABS] - Fixed issue for "Root level readerConfig no longer respected" (#44873) Due to how we pre-fill certain default config values, the recently added 'isConfigEmpty' check was not sufficient to differentiate between an empty and default readerConfig state. This PR overhauls the comparison, replacing the 'isConfigEmpty' with a reflect.DeepEqual against a generated default 'readerConfig' state. This approach avoids the pitfalls of the existing validation and allows both global & container level 'readerConfig' configurations. --------- Co-authored-by: Shourie Ganguly <shourie.ganguly@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Proposed commit message
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs