Skip to content

[filebeat][GCS] - Added missing 'text/csv' content-type filter support#44923

Merged
ShourieG merged 2 commits intoelastic:mainfrom
ShourieG:bugfix/gcs_content_type
Jun 19, 2025
Merged

[filebeat][GCS] - Added missing 'text/csv' content-type filter support#44923
ShourieG merged 2 commits intoelastic:mainfrom
ShourieG:bugfix/gcs_content_type

Conversation

@ShourieG
Copy link
Contributor

@ShourieG ShourieG commented Jun 19, 2025 •
edited
Loading

Type of change

  • Bug

Proposed commit message

Currently content-type "text/csv" did not have official filtering
support even though we support csv decoding. This made objects having this
content type defined were not picked up for processing. This PR as a "bugfix",
adds support for explicit "text/csv" content-type filtering while processing 
each job.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs
@ShourieG ShourieG self-assigned this Jun 19, 2025
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)
@mergify
Copy link
Contributor

mergify bot commented Jun 19, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @ShourieG? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.
@ShourieG ShourieG marked this pull request as ready for review June 19, 2025 08:52
@ShourieG ShourieG requested a review from a team as a code owner June 19, 2025 08:52
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 19, 2025

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)
@ShourieG ShourieG added the backport-active-all Automated backport with mergify to all the active branches label Jun 19, 2025
@ShourieG ShourieG changed the title Added missing 'text/csv' content-type filter support Jun 19, 2025
@ShourieG ShourieG merged commit a2b74e8 into elastic:main Jun 19, 2025
31 of 34 checks passed
@ShourieG ShourieG deleted the bugfix/gcs_content_type branch June 19, 2025 12:19
@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2025

@Mergifyio backport 8.17 8.18 8.19 9.0
@mergify
Copy link
Contributor

mergify bot commented Jun 19, 2025 •
edited
Loading

backport 8.17 8.18 8.19 9.0

✅ Backports have been created

Details
mergify bot pushed a commit that referenced this pull request Jun 19, 2025
@ShourieG @mergify
[filebeat][GCS] - Added missing 'text/csv' content-type filter support (
f1e5dbe 
#44923)

Currently content-type "text/csv" did not have official filtering
support even though we support csv decoding. This made objects having this
content type defined were not picked up for processing. This PR as a "bugfix",
adds support for explicit "text/csv" content-type filtering while processing
each job.

(cherry picked from commit a2b74e8)

# Conflicts:
#	x-pack/filebeat/input/gcs/input_test.go
@mergify mergify bot mentioned this pull request Jun 19, 2025
Merged
6 tasks
mergify bot pushed a commit that referenced this pull request Jun 19, 2025
@ShourieG @mergify
[filebeat][GCS] - Added missing 'text/csv' content-type filter support (
95b40db 
#44923)

Currently content-type "text/csv" did not have official filtering
support even though we support csv decoding. This made objects having this
content type defined were not picked up for processing. This PR as a "bugfix",
adds support for explicit "text/csv" content-type filtering while processing
each job.

(cherry picked from commit a2b74e8)

# Conflicts:
#	x-pack/filebeat/input/gcs/input_test.go
@mergify mergify bot mentioned this pull request Jun 19, 2025
Merged
6 tasks
mergify bot pushed a commit that referenced this pull request Jun 19, 2025
@ShourieG @mergify
[filebeat][GCS] - Added missing 'text/csv' content-type filter support (
5e0c270 
#44923)

Currently content-type "text/csv" did not have official filtering
support even though we support csv decoding. This made objects having this
content type defined were not picked up for processing. This PR as a "bugfix",
adds support for explicit "text/csv" content-type filtering while processing
each job.

(cherry picked from commit a2b74e8)

# Conflicts:
#	x-pack/filebeat/input/gcs/input_test.go
@mergify mergify bot mentioned this pull request Jun 19, 2025
Merged
6 tasks
mergify bot pushed a commit that referenced this pull request Jun 19, 2025
@ShourieG @mergify
[filebeat][GCS] - Added missing 'text/csv' content-type filter support (
11d072c 
#44923)

Currently content-type "text/csv" did not have official filtering
support even though we support csv decoding. This made objects having this
content type defined were not picked up for processing. This PR as a "bugfix",
adds support for explicit "text/csv" content-type filtering while processing
each job.

(cherry picked from commit a2b74e8)

# Conflicts:
#	x-pack/filebeat/input/gcs/input_test.go
@mergify mergify bot mentioned this pull request Jun 19, 2025
Merged
6 tasks
ShourieG added a commit that referenced this pull request Jun 20, 2025
@mergify @ShourieG
[8.17](backport #44923) [filebeat][GCS] - Added missing 'text/csv' co…
59bb0a0 
…ntent-type filter support (#44927)

Currently content-type "text/csv" did not have official filtering
support even though we support csv decoding. This made objects having this
content type defined were not picked up for processing. This PR as a "bugfix",
adds support for explicit "text/csv" content-type filtering while processing 
each job.

---------

Co-authored-by: Shourie Ganguly <shourie.ganguly@elastic.co>
ShourieG added a commit that referenced this pull request Jun 20, 2025
@mergify @ShourieG
[8.18](backport #44923) [filebeat][GCS] - Added missing 'text/csv' co…
de27e01 
…ntent-type filter support (#44928)

Currently content-type "text/csv" did not have official filtering
support even though we support csv decoding. This made objects having this
content type defined were not picked up for processing. This PR as a "bugfix",
adds support for explicit "text/csv" content-type filtering while processing 
each job.

---------

Co-authored-by: Shourie Ganguly <shourie.ganguly@elastic.co>
ShourieG added a commit that referenced this pull request Jun 20, 2025
@mergify @ShourieG
[9.0](backport #44923) [filebeat][GCS] - Added missing 'text/csv' con…
efaa248 
…tent-type filter support (#44930)

Currently content-type "text/csv" did not have official filtering
support even though we support csv decoding. This made objects having this
content type defined were not picked up for processing. This PR as a "bugfix",
adds support for explicit "text/csv" content-type filtering while processing 
each job.

---------

Co-authored-by: Shourie Ganguly <shourie.ganguly@elastic.co>
ShourieG added a commit that referenced this pull request Jun 23, 2025
@mergify @ShourieG
[8.19](backport #44923) [filebeat][GCS] - Added missing 'text/csv' co…
faa4faf 
…ntent-type filter support (#44929)

Currently content-type "text/csv" did not have official filtering
support even though we support csv decoding. This made objects having this content type defined were not picked up for processing. This PR as a "bugfix", adds support for explicit "text/csv" content-type filtering while processing each job.

---------

Co-authored-by: Shourie Ganguly <shourie.ganguly@elastic.co>
@ShourieG ShourieG mentioned this pull request Oct 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-all Automated backport with mergify to all the active branches bugfix Filebeat Filebeat input:GCS Team:Security-Service Integrations Security Service Integrations Team

3 participants

@ShourieG @elasticmachine @kcreddy