Skip to content

[filebeat][ABS] - Segregated max_workers from batch/page size of the response#44992

Merged
ShourieG merged 8 commits intoelastic:mainfrom
ShourieG:abs/batch_size
Jun 26, 2025
Merged

[filebeat][ABS] - Segregated max_workers from batch/page size of the response#44992
ShourieG merged 8 commits intoelastic:mainfrom
ShourieG:abs/batch_size

Conversation

@ShourieG
Copy link
Contributor

@ShourieG ShourieG commented Jun 24, 2025

Type of change

  • Enhancement
  • Docs

Proposed commit message

Decoupled max_workers from the actual page size configurations while
keeping backwards compatibility. A minimum/default value validation was
not implemented intentionally to keep backwards compatibility in
scenarios the users would upgrade the stack but not change  any
relevant configurations.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

None

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@ShourieG ShourieG self-assigned this Jun 24, 2025
@ShourieG ShourieG requested review from a team as code owners June 24, 2025 12:33
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 24, 2025
@github-actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Jun 24, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @ShourieG? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.
@ShourieG ShourieG changed the title [filebeat][ABS] - Segregated batch size from worker count Jun 24, 2025
@ShourieG ShourieG added the Team:Security-Service Integrations Security Service Integrations Team label Jun 24, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 24, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions below.

@mergify
Copy link
Contributor

mergify bot commented Jun 24, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b abs/batch_size upstream/abs/batch_size
git merge upstream/main
git push upstream abs/batch_size
@efd6
Copy link
Contributor

efd6 commented Jun 25, 2025

Please address Colleen's comment before merge.

@ShourieG ShourieG requested a review from colleenmcginnis June 25, 2025 08:44
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShourieG ShourieG merged commit 5963c4b into elastic:main Jun 26, 2025
31 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment