[8.19](backport #45733) Fix error handling from BeatV2Manager reload#45758
Closed
mergify[bot] wants to merge 1 commit into8.19from
Closed
[8.19](backport #45733) Fix error handling from BeatV2Manager reload#45758mergify[bot] wants to merge 1 commit into8.19from
mergify[bot] wants to merge 1 commit into8.19from
Conversation
BeatV2Manager `reload` method calls `reloadInputs`, however it did not handle the errors returned correctly. This commit fixes it by making `reloadInputs`, whenever possible, use a cfgfile.UnitError to indicate the failed unit and handling any unexpected error case/type. (cherry picked from commit d8b1f1a) # Conflicts: # x-pack/libbeat/management/managerV2.go
Contributor
Author
|
Cherry-pick of d8b1f1a has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
6 tasks
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Contributor
Author
|
This pull request is now in conflicts. Could you fix it? 🙏 |
Contributor
|
Closing this backport as the code has diverged too much from the original PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.## Disruptive User Impact## Author's ChecklistHow to test this PR locally
Related issues
inputsinbeat-rendered-config.yaml) #43118## Use cases## Screenshots## LogsThis is an automatic backport of pull request #45733 done by [Mergify](https://mergify.com).