fix(metricbeat): report correct number of entries in conntrack metricset#46140
Merged
mauri870 merged 5 commits intoelastic:mainfrom Aug 26, 2025
Merged
fix(metricbeat): report correct number of entries in conntrack metricset#46140mauri870 merged 5 commits intoelastic:mainfrom
mauri870 merged 5 commits intoelastic:mainfrom
Conversation
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Contributor
|
This pull request is now in conflicts. Could you fix it? 🙏 |
Member
Author
|
@andrzej-stencel @faec Quick reminder for review when you have a moment. |
andrzej-stencel
approved these changes
Aug 26, 2025
Contributor
|
@Mergifyio backport 8.17 8.18 8.19 9.0 9.1 |
Contributor
✅ Backports have been createdDetails
|
6 tasks
6 tasks
6 tasks
6 tasks
6 tasks
mauri870
added a commit
that referenced
this pull request
Aug 26, 2025
…ries in conntrack metricset (#46235) * fix(metricbeat): report correct number of entries in conntrack metricset (#46140) * fix(metricbeat): report correct number of entries in conntrack metricset * adjust changelog * better wording * ignore errcheck in test (cherry picked from commit b93bb0c) * remove unrelated changelog entries --------- Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
The conntrack metricset was summing the
entriesvalue across all CPUs, but this field is identical on each line of/proc/net/stat/nf_conntrack. As a result, the reported count was inflated by a factor of the number of CPU cores.This fixes the issue by reading the entries value only once.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues