dgram.Listener return error on connection failure by belimawr · Pull Request #46302 · elastic/beats

belimawr · 2025-08-28T21:59:54Z

Proposed commit message

The Listener.doRun method previously logged connection failures at a debug level but did not return an error to the caller. This made it difficult for users to understand why a input was not working.

This commit modifies Listener.doRun to return an error when a connection failure occurs and also updates the UDP and Unix inputs to set their status as failed when an error is returned by Listener.Run.

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
~~I have made corresponding changes to the documentation~~
~~I have made corresponding change to the default configuration files~~
I have added tests that prove my fix is effective or that my feature works
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

~~## Disruptive User Impact~~
~~## Author's Checklist~~

How to test this PR locally

Start netcat to listen on a UDP port
```
nc -luvp 3030 &
```
Start sending data to this port using flog
```
docker run -it --rm mingrammer/flog -l -d 1 -s 1 | nc -vu localhost 3030
```
You will start to see some data on your terminal
On another terminal start Filebeat with the following configuration
filebeat.yaml
```
filebeat.inputs:
  - type: udp
    host: 127.0.0.1:3030

output.console:
  enabled: true

logging:
  to_stderr: true
  level: debug
  selectors:
    - "*"
```
```
./filebeat -e -v
```
You should see two log error:

listen udp 127.0.0.1:3030: bind: address already in use

Input 'udp' failed with: listen udp 127.0.0.1:3030: bind: address already in use

Related issues

Closes Filebeat UDP server does not log errors if port is already in use #37216

~~## Use cases~~
~~## Screenshots~~
~~## Logs~~

The Listener.doRun method previously logged connection failures at a debug level but did not return an error to the caller. This made it difficult for users to understand why a input was not working. This commit modifies Listener.doRun to return an error when a connection failure occurs and also updates the UDP and Unix inputs to set their status as failed when an error is returned by Listener.Run.

github-actions · 2025-08-28T22:00:04Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine · 2025-08-28T22:06:38Z

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

mergify · 2025-08-29T21:52:15Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 37216-fix-udp-input-logs upstream/37216-fix-udp-input-logs
git merge upstream/main
git push upstream 37216-fix-udp-input-logs

…put-logs

belimawr · 2025-09-03T20:29:32Z

The tests have been failing because of our seccomp policy, more details on #46333. Once the fix is merged I'll update this PR.

mergify · 2025-09-05T07:06:15Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 37216-fix-udp-input-logs upstream/37216-fix-udp-input-logs
git merge upstream/main
git push upstream 37216-fix-udp-input-logs

…put-logs

TestLogStatusReporter was starting the Filebeat command (github.com/elastic/beats/v7/x-pack/filebeat/cmd.Filebeat()) as part of the test, this loaded the default seccomp policy, blocking system calls needed by subsequent tests like 'pidfd_send_signal'. This commit fixes the problem by running Filebeat as a sub process, like all the other integration tests, thus providing the necessary isolation between tests.

…put-logs

github-actions · 2025-09-10T12:26:03Z

@Mergifyio backport 8.18 8.19 9.0 9.1

mergify · 2025-09-10T12:26:13Z

backport 8.18 8.19 9.0 9.1

✅ Backports have been created

Details

#46508 [8.18](backport #46302) dgram.Listener return error on connection failure has been created for branch 8.18 but encountered conflicts
#46509 [8.19](backport #46302) dgram.Listener return error on connection failure has been created for branch 8.19
#46510 [9.0](backport #46302) dgram.Listener return error on connection failure has been created for branch 9.0 but encountered conflicts
#46511 [9.1](backport #46302) dgram.Listener return error on connection failure has been created for branch 9.1 but encountered conflicts

The Listener.doRun method previously logged connection failures at a debug level but did not return an error to the caller. This made it difficult for users to understand why a input was not working. This commit modifies Listener.doRun to return an error when a connection failure occurs and also updates the UDP and Unix inputs to set their status as failed when an error is returned by Listener.Run. * Add changelog * Fix log level * mage check * double test timeout * Try using 127.0.0.1 instead of all interfaces * TestLogStatusReporter run Filebeat as a sub process TestLogStatusReporter was starting the Filebeat command (github.com/elastic/beats/v7/x-pack/filebeat/cmd.Filebeat()) as part of the test, this loaded the default seccomp policy, blocking system calls needed by subsequent tests like 'pidfd_send_signal'. This commit fixes the problem by running Filebeat as a sub process, like all the other integration tests, thus providing the necessary isolation between tests. (cherry picked from commit 46ae121) # Conflicts: # filebeat/input/unix/input.go # x-pack/filebeat/tests/integration/status_reporter_test.go

The Listener.doRun method previously logged connection failures at a debug level but did not return an error to the caller. This made it difficult for users to understand why a input was not working. This commit modifies Listener.doRun to return an error when a connection failure occurs and also updates the UDP and Unix inputs to set their status as failed when an error is returned by Listener.Run. * Add changelog * Fix log level * mage check * double test timeout * Try using 127.0.0.1 instead of all interfaces * TestLogStatusReporter run Filebeat as a sub process TestLogStatusReporter was starting the Filebeat command (github.com/elastic/beats/v7/x-pack/filebeat/cmd.Filebeat()) as part of the test, this loaded the default seccomp policy, blocking system calls needed by subsequent tests like 'pidfd_send_signal'. This commit fixes the problem by running Filebeat as a sub process, like all the other integration tests, thus providing the necessary isolation between tests. (cherry picked from commit 46ae121)

The Listener.doRun method previously logged connection failures at a debug level but did not return an error to the caller. This made it difficult for users to understand why a input was not working. This commit modifies Listener.doRun to return an error when a connection failure occurs and also updates the UDP and Unix inputs to set their status as failed when an error is returned by Listener.Run. * Add changelog * Fix log level * mage check * double test timeout * Try using 127.0.0.1 instead of all interfaces * TestLogStatusReporter run Filebeat as a sub process TestLogStatusReporter was starting the Filebeat command (github.com/elastic/beats/v7/x-pack/filebeat/cmd.Filebeat()) as part of the test, this loaded the default seccomp policy, blocking system calls needed by subsequent tests like 'pidfd_send_signal'. This commit fixes the problem by running Filebeat as a sub process, like all the other integration tests, thus providing the necessary isolation between tests. (cherry picked from commit 46ae121) # Conflicts: # filebeat/input/unix/input.go # x-pack/filebeat/tests/integration/status_reporter_test.go

The Listener.doRun method previously logged connection failures at a debug level but did not return an error to the caller. This made it difficult for users to understand why a input was not working. This commit modifies Listener.doRun to return an error when a connection failure occurs and also updates the UDP and Unix inputs to set their status as failed when an error is returned by Listener.Run. TestLogStatusReporter was starting the Filebeat command (github.com/elastic/beats/v7/x-pack/filebeat/cmd.Filebeat()) as part of the test, this loaded the default seccomp policy, blocking system calls needed by subsequent tests like 'pidfd_send_signal'. This commit fixes the problem by running Filebeat as a sub process, like all the other integration tests, thus providing the necessary isolation between tests. (cherry picked from commit 46ae121) Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>

The Listener.doRun method previously logged connection failures at a debug level but did not return an error to the caller. This made it difficult for users to understand why a input was not working. This commit modifies Listener.doRun to return an error when a connection failure occurs and also updates the UDP and Unix inputs to set their status as failed when an error is returned by Listener.Run. * Add changelog * Fix log level * mage check * double test timeout * Try using 127.0.0.1 instead of all interfaces * TestLogStatusReporter run Filebeat as a sub process TestLogStatusReporter was starting the Filebeat command (github.com/elastic/beats/v7/x-pack/filebeat/cmd.Filebeat()) as part of the test, this loaded the default seccomp policy, blocking system calls needed by subsequent tests like 'pidfd_send_signal'. This commit fixes the problem by running Filebeat as a sub process, like all the other integration tests, thus providing the necessary isolation between tests.

…lure (#46508) The Listener.doRun method previously logged connection failures at a debug level but did not return an error to the caller. This made it difficult for users to understand why a input was not working. This commit modifies Listener.doRun to return an error when a connection failure occurs and also updates the UDP and Unix inputs to set their status as failed when an error is returned by Listener.Run. TestLogStatusReporter was starting the Filebeat command (github.com/elastic/beats/v7/x-pack/filebeat/cmd.Filebeat()) as part of the test, this loaded the default seccomp policy, blocking system calls needed by subsequent tests like 'pidfd_send_signal'. This commit fixes the problem by running Filebeat as a sub process, like all the other integration tests, thus providing the necessary isolation between tests. (cherry picked from commit 46ae121) # Conflicts: # filebeat/input/unix/input.go # x-pack/filebeat/tests/integration/status_reporter_test.go * Fix merge conflicts * Fix changelog * The UDP input does not report status on 8.18, so remove the test * Fix merge conflicts --------- Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>

…ure (#46510) The Listener.doRun method previously logged connection failures at a debug level but did not return an error to the caller. This made it difficult for users to understand why a input was not working. This commit modifies Listener.doRun to return an error when a connection failure occurs and also updates the UDP and Unix inputs to set their status as failed when an error is returned by Listener.Run. TestLogStatusReporter was starting the Filebeat command (github.com/elastic/beats/v7/x-pack/filebeat/cmd.Filebeat()) as part of the test, this loaded the default seccomp policy, blocking system calls needed by subsequent tests like 'pidfd_send_signal'. This commit fixes the problem by running Filebeat as a sub process, like all the other integration tests, thus providing the necessary isolation between tests. (cherry picked from commit 46ae121) # Conflicts: # filebeat/input/unix/input.go # x-pack/filebeat/tests/integration/status_reporter_test.go --------- Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>

…ure (#46511) The Listener.doRun method previously logged connection failures at a debug level but did not return an error to the caller. This made it difficult for users to understand why a input was not working. This commit modifies Listener.doRun to return an error when a connection failure occurs and also updates the UDP and Unix inputs to set their status as failed when an error is returned by Listener.Run. TestLogStatusReporter was starting the Filebeat command (github.com/elastic/beats/v7/x-pack/filebeat/cmd.Filebeat()) as part of the test, this loaded the default seccomp policy, blocking system calls needed by subsequent tests like 'pidfd_send_signal'. This commit fixes the problem by running Filebeat as a sub process, like all the other integration tests, thus providing the necessary isolation between tests. (cherry picked from commit 46ae121) # Conflicts: # filebeat/input/unix/input.go # x-pack/filebeat/tests/integration/status_reporter_test.go --------- Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>

belimawr self-assigned this Aug 28, 2025

belimawr added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team bugfix backport-active-all Automated backport with mergify to all the active branches labels Aug 28, 2025

botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 28, 2025

Add changelog

6323e50

belimawr marked this pull request as ready for review August 28, 2025 22:06

belimawr requested a review from a team as a code owner August 28, 2025 22:06

belimawr requested review from mauri870 and rdner August 28, 2025 22:06

belimawr added 3 commits August 28, 2025 18:16

Fix log level

db1c86e

mage check

0c7e4fc

double test timeout

28ff7b3

pierrehilbert requested review from khushijain21 and removed request for rdner August 29, 2025 08:22

Try using 127.0.0.1 instead of all interfaces

3e5620c

Merge branch 'main' of github.com:elastic/beats into 37216-fix-udp-in…

f582ae2

…put-logs

mauri870 approved these changes Sep 1, 2025

View reviewed changes

belimawr mentioned this pull request Sep 3, 2025

Filebeat config option restart_on_cert_change consistently causes crash #46333

Closed

belimawr added 3 commits September 9, 2025 10:21

Merge branch 'main' of github.com:elastic/beats into 37216-fix-udp-in…

14e9cc2

…put-logs

Merge branch 'main' of github.com:elastic/beats into 37216-fix-udp-in…

3753b97

…put-logs

belimawr merged commit 46ae121 into elastic:main Sep 10, 2025
49 of 52 checks passed

mergify bot mentioned this pull request Sep 10, 2025

[9.1](backport #46302) dgram.Listener return error on connection failure #46511

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dgram.Listener return error on connection failure#46302

dgram.Listener return error on connection failure#46302
belimawr merged 10 commits intoelastic:mainfrom
belimawr:37216-fix-udp-input-logs

belimawr commented Aug 28, 2025 •

edited

Loading

github-actions bot commented Aug 28, 2025

elasticmachine commented Aug 28, 2025

mergify bot commented Aug 29, 2025

belimawr commented Sep 3, 2025

mergify bot commented Sep 5, 2025

Uh oh!

github-actions bot commented Sep 10, 2025

mergify bot commented Sep 10, 2025 •

edited

Loading

Labels

3 participants

Conversation

belimawr commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed commit message

Checklist

How to test this PR locally

Related issues

github-actions bot commented Aug 28, 2025

🤖 GitHub comments

elasticmachine commented Aug 28, 2025

mergify bot commented Aug 29, 2025

belimawr commented Sep 3, 2025

mergify bot commented Sep 5, 2025

Uh oh!

github-actions bot commented Sep 10, 2025

mergify bot commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Labels

3 participants

belimawr commented Aug 28, 2025 •

edited

Loading

mergify bot commented Sep 10, 2025 •

edited

Loading