Add close to conditions processors

[leehinman]

Proposed commit message

Add Close method to the conditionals processors if any of the underlying processors have a Close method. Without a Close method, processor definitions like the following would not have their Close method called.

processors:
  - add_host_metadata:
     when.not.contains.tags: "forwarded"

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

none

Author's Checklist

• [ ]

How to test this PR locally

cd libbeat/processors
go test .

Related issues

• Relates https://github.com/elastic/ingest-dev/issues/6063
• Closes Stateful processors wrapped in conditionals aren't cleaned up #46575

Use cases

Screenshots

Logs

[github-actions]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b conditions_close upstream/conditions_close
git merge upstream/main
git push upstream conditions_close

[mergify]

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @leehinman? 🙏.
For such, you'll need to label your PR with:

• The upcoming major version of the Elastic Stack
• The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
• backport-active-all is the label that automatically backports to all active branches.
• backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
• backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

[elasticmachine]

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

[swiatekm]

Here's an issue I filed for this problem: #46575. I assigned it to you @leehinman given that you're already solving this.

[leehinman]

Putting in Draft because we have to figure out the conditionals inside the script processor

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b conditions_close upstream/conditions_close
git merge upstream/main
git push upstream conditions_close

[github-actions]

@Mergifyio backport 8.19 9.0 9.1 9.2

[mergify]

backport 8.19 9.0 9.1 9.2

✅ Backports have been created

Details

• #47287 [8.19](backport #46653) Add close to conditions processors has been created for branch 8.19
• #47286 [9.0](backport #46653) Add close to conditions processors has been created for branch 9.0 but encountered conflicts
• #47285 [9.1](backport #46653) Add close to conditions processors has been created for branch 9.1
• #47288 [9.2](backport #46653) Add close to conditions processors has been created for branch 9.2