Skip to content

x-pack/filebeat/input/{cel,httpjson,internal/dpop}: add support for DPoP OAuth for Okta#47441

Merged
efd6 merged 5 commits intoelastic:mainfrom
efd6:15056-cel-httpjson
Nov 13, 2025
Merged

x-pack/filebeat/input/{cel,httpjson,internal/dpop}: add support for DPoP OAuth for Okta#47441
efd6 merged 5 commits intoelastic:mainfrom
efd6:15056-cel-httpjson

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Nov 4, 2025 •
edited
Loading

Proposed commit message

See title.

Note

This is initially included in the inputs/internal directory. It may be moved in future if it is needed for other packages that cannot see that import path. The API is unstable at this stage, with planned changes (dependent on the json/v2 experiment outcomes).

Note

Claude was used for some code generation in this PR.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works. Where relevant, I have used the stresstest.sh script to run them under stress conditions and race detector to verify their stability.
  • I have added an entry in ./changelog/fragments using the changelog tool.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs
@efd6 efd6 self-assigned this Nov 4, 2025
@efd6 efd6 added enhancement Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team backport-8.19 Automated backport to the 8.19 branch backport-9.2 Automated backport to the 9.2 branch labels Nov 4, 2025
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)
@efd6 efd6 force-pushed the 15056-cel-httpjson branch 2 times, most recently from 20b7225 to 53a35c0 Compare November 4, 2025 03:23
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025 •
edited
Loading

🔍 Preview links for changed docs
@efd6 efd6 force-pushed the 15056-cel-httpjson branch from 53a35c0 to 20f9be4 Compare November 4, 2025 03:37
@efd6 efd6 marked this pull request as ready for review November 4, 2025 05:30
@efd6 efd6 requested review from a team as code owners November 4, 2025 05:30
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 4, 2025

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)
@efd6 efd6 requested review from ShourieG, orestisfl and rdner November 4, 2025 05:30
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Nov 4, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 4, 2025

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)
ShourieG
ShourieG reviewed Nov 5, 2025
View reviewed changes
ShourieG
ShourieG approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, from my end
orestisfl
orestisfl approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@orestisfl orestisfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would address the golangci-lint warnings

The rand one can be disabled:

diff --git a/.golangci.yml b/.golangci.yml
index 20fbe3b1ff..9496b174c2 100755
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -54,6 +54,7 @@ linters:
         - (github.com/elastic/elastic-agent-libs/mapstr.M).Put
         - github.com/elastic/elastic-agent-libs/logp.TestingSetup
         - github.com/elastic/elastic-agent-libs/logp.DevelopmentSetup
+        - crypto/rand.Read
     errorlint:
       errorf: true
       asserts: true
vishaangelova
vishaangelova approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@vishaangelova vishaangelova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM
orestisfl
orestisfl reviewed Nov 6, 2025
View reviewed changes
rdner
rdner reviewed Nov 7, 2025
View reviewed changes
@efd6 efd6 force-pushed the 15056-cel-httpjson branch from 20e02ea to 2426512 Compare November 10, 2025 20:30
andrewkroh
andrewkroh reviewed Nov 12, 2025
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice clean implementation of DPoP.

Have you been able to validate this with an Okta instance?
@efd6
Copy link
Contributor Author

efd6 commented Nov 12, 2025 •
edited
Loading

Have you been able to validate this with an Okta instance?

I have not yet been able to do this yet.
@efd6 efd6 force-pushed the 15056-cel-httpjson branch from 7e2a798 to e8ca0e9 Compare November 12, 2025 04:50
@efd6 efd6 requested a review from andrewkroh November 12, 2025 04:51
@efd6 efd6 merged commit 667958e into elastic:main Nov 13, 2025
40 checks passed
mergify bot pushed a commit that referenced this pull request Nov 13, 2025
@efd6 @mergify
x-pack/filebeat/input/{cel,httpjson,internal/dpop}: add support for D…
94c9847 
…PoP OAuth for Okta (#47441)

(cherry picked from commit 667958e)
mergify bot pushed a commit that referenced this pull request Nov 13, 2025
@efd6 @mergify
x-pack/filebeat/input/{cel,httpjson,internal/dpop}: add support for D…
4f9e52d 
…PoP OAuth for Okta (#47441)

(cherry picked from commit 667958e)

# Conflicts:
#	docs/reference/filebeat/filebeat-input-cel.md
#	docs/reference/filebeat/filebeat-input-httpjson.md
This was referenced Nov 13, 2025
Merged
Merged
@vishaangelova vishaangelova mentioned this pull request Nov 13, 2025
Merged
6 tasks
efd6 added a commit that referenced this pull request Nov 13, 2025
@mergify @efd6
x-pack/filebeat/input/{cel,httpjson,internal/dpop}: add support for D…
b62b4da 
…PoP OAuth for Okta (#47441) (#47609)

(cherry picked from commit 667958e)

Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
efd6 added a commit that referenced this pull request Nov 13, 2025
@mergify @efd6
[8.19](backport #47441) x-pack/filebeat/input/{cel,httpjson,internal/…
0dbeaae 
…dpop}: add support for DPoP OAuth for Okta (#47608)

* x-pack/filebeat/input/{cel,httpjson,internal/dpop}: add support for DPoP OAuth for Okta (#47441)

(cherry picked from commit 667958e)

# Conflicts:
#	docs/reference/filebeat/filebeat-input-cel.md
#	docs/reference/filebeat/filebeat-input-httpjson.md

* move changelog to v8 changelog file
* revert markdown doc addition
* add asciidoc documentation

---------

Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
This was referenced Nov 17, 2025
Merged
Merged
andrzej-stencel pushed a commit to andrzej-stencel/beats that referenced this pull request Dec 1, 2025
@efd6 @andrzej-stencel
x-pack/filebeat/input/{cel,httpjson,internal/dpop}: add support for D…
4a20d30 
…PoP OAuth for Okta (elastic#47441)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.19 Automated backport to the 8.19 branch backport-9.2 Automated backport to the 9.2 branch enhancement Filebeat Filebeat Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Security-Service Integrations Security Service Integrations Team

8 participants

@efd6 @elasticmachine @rdner @andrewkroh @orestisfl @vishaangelova @ShourieG @pierrehilbert