x-pack/filebeat/input/{azureblobstorage, gcs}: Remove leading BOM from JSON text#47508
Merged
kcreddy merged 3 commits intoelastic:mainfrom Nov 10, 2025
Merged
x-pack/filebeat/input/{azureblobstorage, gcs}: Remove leading BOM from JSON text#47508kcreddy merged 3 commits intoelastic:mainfrom
kcreddy merged 3 commits intoelastic:mainfrom
Conversation
Contributor
🤖 GitHub commentsJust comment with:
|
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Contributor
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
efd6
reviewed
Nov 7, 2025
efd6
approved these changes
Nov 10, 2025
mergify bot
pushed a commit
that referenced
this pull request
Nov 10, 2025
…m JSON text (#47508) x-pack/filebeat/input/{azureblobstorage, gcs}: Remove leading BOM from JSON text When parsing JSON leading BOMs are identified in azureblobstorage input. Currently the input cannot handle this and fails indicating a malformed JSON but without the position and characters leading to the failure. This PR handle the leading BOMs in JSON and removes them in azureblobstorage input. Also improve error reporting from malformed JSON. Since a similar handling is observed in GCS input, the change is replicated there. (cherry picked from commit 823ee2a)
mergify bot
pushed a commit
that referenced
this pull request
Nov 10, 2025
…m JSON text (#47508) x-pack/filebeat/input/{azureblobstorage, gcs}: Remove leading BOM from JSON text When parsing JSON leading BOMs are identified in azureblobstorage input. Currently the input cannot handle this and fails indicating a malformed JSON but without the position and characters leading to the failure. This PR handle the leading BOMs in JSON and removes them in azureblobstorage input. Also improve error reporting from malformed JSON. Since a similar handling is observed in GCS input, the change is replicated there. (cherry picked from commit 823ee2a)
mergify bot
pushed a commit
that referenced
this pull request
Nov 10, 2025
…m JSON text (#47508) x-pack/filebeat/input/{azureblobstorage, gcs}: Remove leading BOM from JSON text When parsing JSON leading BOMs are identified in azureblobstorage input. Currently the input cannot handle this and fails indicating a malformed JSON but without the position and characters leading to the failure. This PR handle the leading BOMs in JSON and removes them in azureblobstorage input. Also improve error reporting from malformed JSON. Since a similar handling is observed in GCS input, the change is replicated there. (cherry picked from commit 823ee2a)
6 tasks
kcreddy
added a commit
that referenced
this pull request
Nov 10, 2025
…m JSON text (#47508) (#47543) x-pack/filebeat/input/{azureblobstorage, gcs}: Remove leading BOM from JSON text When parsing JSON leading BOMs are identified in azureblobstorage input. Currently the input cannot handle this and fails indicating a malformed JSON but without the position and characters leading to the failure. This PR handle the leading BOMs in JSON and removes them in azureblobstorage input. Also improve error reporting from malformed JSON. Since a similar handling is observed in GCS input, the change is replicated there. (cherry picked from commit 823ee2a) Co-authored-by: Krishna Chaitanya Reddy Burri <krishnachaitanyareddy.burri@elastic.co>
kcreddy
added a commit
that referenced
this pull request
Nov 10, 2025
…m JSON text (#47508) (#47542) x-pack/filebeat/input/{azureblobstorage, gcs}: Remove leading BOM from JSON text When parsing JSON leading BOMs are identified in azureblobstorage input. Currently the input cannot handle this and fails indicating a malformed JSON but without the position and characters leading to the failure. This PR handle the leading BOMs in JSON and removes them in azureblobstorage input. Also improve error reporting from malformed JSON. Since a similar handling is observed in GCS input, the change is replicated there. (cherry picked from commit 823ee2a) Co-authored-by: Krishna Chaitanya Reddy Burri <krishnachaitanyareddy.burri@elastic.co>
kcreddy
added a commit
that referenced
this pull request
Nov 10, 2025
…m JSON text (#47508) (#47544) x-pack/filebeat/input/{azureblobstorage, gcs}: Remove leading BOM from JSON text When parsing JSON leading BOMs are identified in azureblobstorage input. Currently the input cannot handle this and fails indicating a malformed JSON but without the position and characters leading to the failure. This PR handle the leading BOMs in JSON and removes them in azureblobstorage input. Also improve error reporting from malformed JSON. Since a similar handling is observed in GCS input, the change is replicated there. (cherry picked from commit 823ee2a) Co-authored-by: Krishna Chaitanya Reddy Burri <krishnachaitanyareddy.burri@elastic.co>
andrzej-stencel
pushed a commit
to andrzej-stencel/beats
that referenced
this pull request
Dec 1, 2025
…m JSON text (elastic#47508) x-pack/filebeat/input/{azureblobstorage, gcs}: Remove leading BOM from JSON text When parsing JSON leading BOMs are identified in azureblobstorage input. Currently the input cannot handle this and fails indicating a malformed JSON but without the position and characters leading to the failure. This PR handle the leading BOMs in JSON and removes them in azureblobstorage input. Also improve error reporting from malformed JSON. Since a similar handling is observed in GCS input, the change is replicated there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs