Conversation
…mprove logging (#47585) Previously, when findObjectBy was called and the connection was closing, the reconnect method would both hold the lock and call connect which attempts to then gain the lock, resulting in a deadlock. Reduce the level of locking; I believe this can be reduced further, but the concurrent use protections here are unclear, so I have not gone further. Also improve debug logging during dial and query. (cherry picked from commit c2e6257) # Conflicts: # libbeat/processors/translate_ldap_attribute/translate_ldap_attribute.go
Contributor
Author
|
Cherry-pick of c2e6257 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Contributor
🤖 GitHub commentsJust comment with:
|
Contributor
|
Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform) |
Contributor
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
The 9.1 branch does not have the preferred behaviour, but the existing behaviour is retained to avoid conflating changes.
efd6
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs
This is an automatic backport of pull request #47585 done by [Mergify](https://mergify.com).