Skip to content

[9.2](backport #47585) libbeat/processors/translate_ldap_attribute: fix double locking and improve logging#47592

Merged
efd6 merged 1 commit into9.2from
mergify/bp/9.2/pr-47585
Nov 12, 2025
Merged

[9.2](backport #47585) libbeat/processors/translate_ldap_attribute: fix double locking and improve logging#47592
efd6 merged 1 commit into9.2from
mergify/bp/9.2/pr-47585

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Nov 12, 2025

Proposed commit message

libbeat/processors/translate_ldap_attribute: fix double locking and improve logging

Previously, when findObjectBy was called and the connection was closing,
the reconnect method would both hold the lock and call connect which
attempts to then gain the lock, resulting in a deadlock. Reduce the
level of locking; I believe this can be reduced further, but the
concurrent use protections here are unclear, so I have not gone further.

Also improve debug logging during dial and query.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works. Where relevant, I have used the stresstest.sh script to run them under stress conditions and race detector to verify their stability.
  • I have added an entry in ./changelog/fragments using the changelog tool.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs


This is an automatic backport of pull request #47585 done by [Mergify](https://mergify.com).
…mprove logging (#47585)

Previously, when findObjectBy was called and the connection was closing,
the reconnect method would both hold the lock and call connect which
attempts to then gain the lock, resulting in a deadlock. Reduce the
level of locking; I believe this can be reduced further, but the
concurrent use protections here are unclear, so I have not gone further.

Also improve debug logging during dial and query.

(cherry picked from commit c2e6257)
@mergify mergify bot added the backport label Nov 12, 2025
@mergify mergify bot requested review from a team as code owners November 12, 2025 11:42
@mergify mergify bot assigned efd6 Nov 12, 2025
@mergify mergify bot requested review from AndersonQ and belimawr and removed request for a team November 12, 2025 11:42
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 12, 2025
@github-actions
Copy link
Contributor

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)
@github-actions github-actions bot added enhancement Filebeat Filebeat bugfix Team:Security-Service Integrations Security Service Integrations Team Team:Security-Windows Platform Windows Platform Team in Security Solution labels Nov 12, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elasticmachine
Copy link
Contributor

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 12, 2025
@efd6 efd6 merged commit 32d0a50 into 9.2 Nov 12, 2025
212 checks passed
@efd6 efd6 deleted the mergify/bp/9.2/pr-47585 branch November 12, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport bugfix enhancement Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team Team:Security-Windows Platform Windows Platform Team in Security Solution

2 participants