Skip to content

feat: add resource pool id to vSphere's cluster metricset#47883

Merged
stefans-elastic merged 12 commits intoelastic:mainfrom
stefans-elastic:vsphere-resPoolId
Dec 15, 2025
Merged

feat: add resource pool id to vSphere's cluster metricset#47883
stefans-elastic merged 12 commits intoelastic:mainfrom
stefans-elastic:vsphere-resPoolId

Conversation

@stefans-elastic
Copy link
Contributor

@stefans-elastic stefans-elastic commented Dec 3, 2025

Proposed commit message

See title

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works. Where relevant, I have used the stresstest.sh script to run them under stress conditions and race detector to verify their stability.
  • I have added an entry in ./changelog/fragments using the changelog tool.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Screenshot 2025-12-03 at 10 30 59

Logs
@stefans-elastic stefans-elastic requested a review from a team as a code owner December 3, 2025 12:37
@stefans-elastic stefans-elastic added enhancement Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team labels Dec 3, 2025
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)
@mergify
Copy link
Contributor

mergify bot commented Dec 3, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @stefans-elastic? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.
@stefans-elastic stefans-elastic requested a review from a team as a code owner December 3, 2025 13:47
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025 •
edited
Loading

🔍 Preview links for changed docs
shmsr
shmsr reviewed Dec 4, 2025
View reviewed changes
@shmsr shmsr requested a review from a team December 4, 2025 08:18
@stefans-elastic stefans-elastic requested a review from shmsr December 4, 2025 09:47
colleenmcginnis
colleenmcginnis reviewed Dec 4, 2025
View reviewed changes
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the lack of backport labels, I assume this change is going into the next minor version. If that's not correct, feel free to adjust. You'll need to regenerate the docs after making this change.
stefans-elastic and others added 2 commits December 5, 2025 14:06
@stefans-elastic @colleenmcginnis
Update metricbeat/module/vsphere/cluster/_meta/fields.yml
2250b59 
Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com>
@stefans-elastic
make update
bf77127
ishleenk17
ishleenk17 reviewed Dec 9, 2025
View reviewed changes
@stefans-elastic
Copy link
Contributor Author

stefans-elastic commented Dec 9, 2025

@ishleenk17 I would like to ask your opinion on which versions do you think this should be backported to? backport-active-9 ?
@ishleenk17
Copy link
Member

ishleenk17 commented Dec 10, 2025

@ishleenk17 I would like to ask your opinion on which versions do you think this should be backported to? backport-active-9 ?

Since its a new metric support, I would be ok to have it backported to active-9.x
@ishleenk17
Copy link
Member

ishleenk17 commented Dec 10, 2025

@ishleenk17 I would like to ask your opinion on which versions do you think this should be backported to? backport-active-9 ?

Since its a new metric support, I would be ok to have it backported to active-9.x

@colleenmcginnis : Would the label 9.3 change in case we are backporting ?
@colleenmcginnis
Copy link
Contributor

colleenmcginnis commented Dec 10, 2025

@colleenmcginnis : Would the label 9.3 change in case we are backporting ?

Yes. You should update the version number in metricbeat/module/vsphere/cluster/_meta/fields.yml to the earliest version it is being added to.
@stefans-elastic
Copy link
Contributor Author

stefans-elastic commented Dec 10, 2025

@colleenmcginnis : Would the label 9.3 change in case we are backporting ?

Yes. You should update the version number in metricbeat/module/vsphere/cluster/_meta/fields.yml to the earliest version it is being added to.

if I'm reading release schedule correctly the value should be 9.1.10, is it correct?
@stefans-elastic stefans-elastic added the backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches label Dec 11, 2025
@stefans-elastic stefans-elastic merged commit d29d293 into elastic:main Dec 15, 2025
52 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025

@Mergifyio backport 9.1 9.2
@mergify
Copy link
Contributor

mergify bot commented Dec 15, 2025 •
edited
Loading

backport 9.1 9.2

✅ Backports have been created

Details
mergify bot pushed a commit that referenced this pull request Dec 15, 2025
@stefans-elastic @shmsr
@colleenmcginnis @mergify
feat: add resource pool id to vSphere's cluster metricset (#47883)
0230199 
* feat: add resource pool id to vSphere's cluster metricset

* fix field description

* fix field description

* fix unit test

* updated docs/reference/metricbeat/exported-fields-vsphere.md

* Apply suggestions from code review

Co-authored-by: subham s <sarkar.subhams2@gmail.com>

* fix change kind in changelog

* make update

* Update metricbeat/module/vsphere/cluster/_meta/fields.yml

Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com>

* make update

* update ga version of resourcepool.id field

---------

Co-authored-by: subham s <sarkar.subhams2@gmail.com>
Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com>
(cherry picked from commit d29d293)
mergify bot pushed a commit that referenced this pull request Dec 15, 2025
@stefans-elastic @shmsr
@colleenmcginnis @mergify
feat: add resource pool id to vSphere's cluster metricset (#47883)
65a13fc 
* feat: add resource pool id to vSphere's cluster metricset

* fix field description

* fix field description

* fix unit test

* updated docs/reference/metricbeat/exported-fields-vsphere.md

* Apply suggestions from code review

Co-authored-by: subham s <sarkar.subhams2@gmail.com>

* fix change kind in changelog

* make update

* Update metricbeat/module/vsphere/cluster/_meta/fields.yml

Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com>

* make update

* update ga version of resourcepool.id field

---------

Co-authored-by: subham s <sarkar.subhams2@gmail.com>
Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com>
(cherry picked from commit d29d293)
This was referenced Dec 15, 2025
Merged
Merged
stefans-elastic added a commit that referenced this pull request Dec 16, 2025
@mergify @stefans-elastic
@shmsr @colleenmcginnis
feat: add resource pool id to vSphere's cluster metricset (#47883) (#…
0c95e7a 
…48083)

* feat: add resource pool id to vSphere's cluster metricset

* fix field description

* fix field description

* fix unit test

* updated docs/reference/metricbeat/exported-fields-vsphere.md

* Apply suggestions from code review



* fix change kind in changelog

* make update

* Update metricbeat/module/vsphere/cluster/_meta/fields.yml



* make update

* update ga version of resourcepool.id field

---------



(cherry picked from commit d29d293)

Co-authored-by: stefans-elastic <stefan.stas@elastic.co>
Co-authored-by: subham s <sarkar.subhams2@gmail.com>
Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com>
stefans-elastic added a commit that referenced this pull request Dec 16, 2025
@mergify @stefans-elastic
@shmsr @colleenmcginnis
feat: add resource pool id to vSphere's cluster metricset (#47883) (#…
122e532 
…48082)

* feat: add resource pool id to vSphere's cluster metricset

* fix field description

* fix field description

* fix unit test

* updated docs/reference/metricbeat/exported-fields-vsphere.md

* Apply suggestions from code review



* fix change kind in changelog

* make update

* Update metricbeat/module/vsphere/cluster/_meta/fields.yml



* make update

* update ga version of resourcepool.id field

---------



(cherry picked from commit d29d293)

Co-authored-by: stefans-elastic <stefan.stas@elastic.co>
Co-authored-by: subham s <sarkar.subhams2@gmail.com>
Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com>
@ishleenk17
Copy link
Member

ishleenk17 commented Dec 17, 2025

@stefans-elastic : We should add this support of new metrics in the vSphere integration too.
Please create a ticket for that as well.
This was referenced Dec 17, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches enhancement Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team

4 participants

@stefans-elastic @ishleenk17 @colleenmcginnis @shmsr