Skip to content

[9.1](backport #47950) [meraki] improve defensive checks to prevent panics#47951

Merged
gpop63 merged 1 commit into9.1from
mergify/bp/9.1/pr-47950
Dec 7, 2025
Merged

[9.1](backport #47950) [meraki] improve defensive checks to prevent panics#47951
gpop63 merged 1 commit into9.1from
mergify/bp/9.1/pr-47950

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Dec 7, 2025

Overview

Fix nil pointer dereference panic in getDeviceSwitchports when the Meraki API returns switch port data for devices not present in the local devices map. + more safety checks to prevent panics

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works. Where relevant, I have used the stresstest.sh script to run them under stress conditions and race detector to verify their stability.
  • I have added an entry in ./changelog/fragments using the changelog tool.
    This is an automatic backport of pull request [meraki] improve defensive checks to prevent panics #47950 done by Mergify.
@gpop63 @shmsr @mergify
[meraki] improve defensive checks to prevent panics (#47950)
eb4bd0d 
* check if device exists in the map

* add fragment

* add more safety checks

* Fix more potential nil panic(s)

* Fix more potential nil panic(s)

* update fragment

---------

Co-authored-by: subham sarkar <subham.sarkar@elastic.co>
(cherry picked from commit 1c8215c)
@mergify mergify bot added the backport label Dec 7, 2025
@mergify mergify bot requested review from a team as code owners December 7, 2025 16:23
@mergify mergify bot added the backport label Dec 7, 2025
@mergify mergify bot assigned gpop63 Dec 7, 2025
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 7, 2025
@mergify mergify bot requested review from VihasMakwana and orestisfl and removed request for a team December 7, 2025 16:23
@mergify mergify bot mentioned this pull request Dec 7, 2025
Merged
6 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)
@github-actions github-actions bot added the Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team label Dec 7, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 7, 2025
@gpop63 gpop63 merged commit 5a29b3c into 9.1 Dec 7, 2025
38 checks passed
@gpop63 gpop63 deleted the mergify/bp/9.1/pr-47950 branch December 7, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team

1 participant

@gpop63