[filebeat] [s3 input] Use configured region when non_aws_bucket_name is defined#48534
Conversation
…e is defined Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
🤖 GitHub commentsJust comment with:
|
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
🔍 Preview links for changed docs |
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
|
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
changelog/fragments/1769424344-filebeat-awss3-input-fix-region-detection.yaml
Outdated
Show resolved
Hide resolved
mauri870
left a comment
There was a problem hiding this comment.
I skimmed through the changes and they look fine to me, but I'm not very familiar with the S3 input to give detailed feedback.
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
changelog/fragments/1769424344-filebeat-awss3-input-fix-region-detection.yaml
Outdated
Show resolved
Hide resolved
Kavindu-Dodan
left a comment
There was a problem hiding this comment.
LGTM 🙏
I left one nit - https://github.com/elastic/beats/pull/48534/changes#r2783833944 feel free to check if it makes sense and merge when ready
…-detection.yaml Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
✅ Vale Linting ResultsNo issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
|
@Mergifyio backport 8.19 9.2 9.3 |
✅ Backports have been createdDetails
Cherry-pick of b34256a has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
|
…` is defined (#48534) * filebeat s3 input: use user-configured region when non_aws_bucket_name is defined Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * add changelog fragment Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * add configuration validation and corresponding config tests Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * add more detailed fragment summary Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * drop redundant region check in createS3API, rely on config validation Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * Update changelog/fragments/1769424344-filebeat-awss3-input-fix-region-detection.yaml Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com> --------- Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com> (cherry picked from commit b34256a) # Conflicts: # docs/reference/filebeat/filebeat-input-aws-s3.md
…` is defined (#48534) * filebeat s3 input: use user-configured region when non_aws_bucket_name is defined Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * add changelog fragment Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * add configuration validation and corresponding config tests Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * add more detailed fragment summary Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * drop redundant region check in createS3API, rely on config validation Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * Update changelog/fragments/1769424344-filebeat-awss3-input-fix-region-detection.yaml Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com> --------- Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com> (cherry picked from commit b34256a)
…` is defined (#48534) * filebeat s3 input: use user-configured region when non_aws_bucket_name is defined Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * add changelog fragment Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * add configuration validation and corresponding config tests Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * add more detailed fragment summary Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * drop redundant region check in createS3API, rely on config validation Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * Update changelog/fragments/1769424344-filebeat-awss3-input-fix-region-detection.yaml Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com> --------- Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com> (cherry picked from commit b34256a)
…` is defined (#48534) (#48781) * filebeat s3 input: use user-configured region when non_aws_bucket_name is defined * add changelog fragment * add configuration validation and corresponding config tests * add more detailed fragment summary * drop redundant region check in createS3API, rely on config validation * Update changelog/fragments/1769424344-filebeat-awss3-input-fix-region-detection.yaml --------- (cherry picked from commit b34256a) Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> Co-authored-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
…` is defined (#48534) (#48782) * filebeat s3 input: use user-configured region when non_aws_bucket_name is defined * add changelog fragment * add configuration validation and corresponding config tests * add more detailed fragment summary * drop redundant region check in createS3API, rely on config validation * Update changelog/fragments/1769424344-filebeat-awss3-input-fix-region-detection.yaml --------- (cherry picked from commit b34256a) Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> Co-authored-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
…hen `non_aws_bucket_name` is defined (#48780) * [filebeat] [s3 input] Use configured region when `non_aws_bucket_name` is defined (#48534) * filebeat s3 input: use user-configured region when non_aws_bucket_name is defined Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * add changelog fragment Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * add configuration validation and corresponding config tests Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * add more detailed fragment summary Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * drop redundant region check in createS3API, rely on config validation Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * Update changelog/fragments/1769424344-filebeat-awss3-input-fix-region-detection.yaml Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com> --------- Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com> (cherry picked from commit b34256a) # Conflicts: # docs/reference/filebeat/filebeat-input-aws-s3.md * fix the conflict; add information about the region configuration with non_aws_bucket_name for s3 input Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> --------- Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> Co-authored-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Proposed commit message
non_aws_bucket_nameis definedGetBucketLocationAPI to determine the bucket region, whennon_aws_bucket_nameis used for S3-compatible services (e.g., Alibaba Cloud OSS, MinIO, DigitalOcean Spaces)Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.Disruptive User Impact
Now
regionconfiguration parameter is required whennon_aws_bucket_nameis setAuthor's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs