Fix body int overflow issues in packetbeat HTTP parser, linter fixes#48563
Fix body int overflow issues in packetbeat HTTP parser, linter fixes#48563fearful-symmetry merged 5 commits intoelastic:mainfrom
Conversation
🤖 GitHub commentsJust comment with:
|
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
There was a problem hiding this comment.
Pull request overview
This PR addresses integer overflow vulnerabilities in the packetbeat HTTP parser by adding validation checks before type conversions to uint64 and uint16. It also includes linter fixes that standardize error message formatting to lowercase.
Changes:
- Added overflow checks for status codes, body sizes, and chunk sizes before converting to unsigned integer types
- Standardized error messages to use lowercase formatting per linting conventions
- Added a changelog fragment documenting the bug fix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packetbeat/protos/http/http_parser.go | Added integer overflow validation checks and standardized error message casing |
| changelog/fragments/1769534243-add-int-checks-to-http-parser.yaml | Added changelog entry documenting the HTTP parser integer overflow bug fixes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform) |
|
@Mergifyio backport 8.19 9.2 9.3 |
✅ Backports have been createdDetails
|
Proposed commit message
A small PR that fixes a handful of integer overflow issues in the packetbeat HTTP parser.
Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.