Skip to content

Update CSP integration input types - #331

Merged
uri-weisman merged 2 commits into
elastic:mainfrom
uri-weisman:update_config
Aug 14, 2022
Merged

Update CSP integration input types#331
uri-weisman merged 2 commits into
elastic:mainfrom
uri-weisman:update_config

Conversation

@uri-weisman

@uri-weisman uri-weisman commented Aug 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR updates the expected integration's input types and rename dataYaml to runtimeCfg.

Related:
@mergify

mergify Bot commented Aug 8, 2022

Copy link
Copy Markdown
Contributor

This pull request does not have a backport label. Could you fix it @uri-weisman? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.
@mergify mergify Bot added the backport-skip label Aug 8, 2022
@uri-weisman uri-weisman changed the title Update cloudbeat input types Aug 8, 2022
@github-actions

github-actions Bot commented Aug 8, 2022

Copy link
Copy Markdown

Cloudbeat CI 🤖

Allure Report: http://csp-allure-reports.s3.amazonaws.com/allure_reports/cloudbeat/prs/331/index.html
@uri-weisman
uri-weisman marked this pull request as ready for review August 8, 2022 13:29
@uri-weisman
uri-weisman requested a review from a team as a code owner August 8, 2022 13:29
@amirbenun

amirbenun commented Aug 9, 2022

Copy link
Copy Markdown
Contributor

Thanks @uri-weisman ,
Can you please link the matching PR to the integration?
eyalkraft
eyalkraft approved these changes Aug 9, 2022
View reviewed changes

@eyalkraft eyalkraft left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to merge with Kibana and the integration
@uri-weisman
uri-weisman merged commit 44ffd5e into elastic:main Aug 14, 2022
@uri-weisman
uri-weisman deleted the update_config branch August 14, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment