Skip to content

Update CNVM findings schema - #912

Merged
uri-weisman merged 7 commits into
elastic:mainfrom
uri-weisman:fix_schema
May 4, 2023
Merged

Update CNVM findings schema#912
uri-weisman merged 7 commits into
elastic:mainfrom
uri-weisman:fix_schema

Conversation

@uri-weisman

@uri-weisman uri-weisman commented Apr 30, 2023

Copy link
Copy Markdown
Collaborator

Summary of your changes

  1. class -> vulnerability.class
  2. target -> package.path
  3. type -> package.type
  4. Move vulnerability.package to be directly under package as defined in the technical index and in ECS.
  5. Upgrade elastic-package binary to the latest.

Related Issues

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary README/documentation (if appropriate)

Screenshot 2023-05-01 at 13 45 13

Screenshot 2023-05-01 at 13 45 35

@mergify

mergify Bot commented Apr 30, 2023

Copy link
Copy Markdown
Contributor

This pull request does not have a backport label. Could you fix it @uri-weisman? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.
@github-actions

Copy link
Copy Markdown
@uri-weisman
uri-weisman marked this pull request as ready for review May 1, 2023 10:46
@uri-weisman
uri-weisman requested a review from a team as a code owner May 1, 2023 10:46

@amirbenun amirbenun left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Do we want to backport?
  2. In #897 there is also cluster_id do we want to change it on a different PR?
@oren-zohar

Copy link
Copy Markdown
Collaborator

@kfirpeled do we want to backport this?

@uri-weisman

Copy link
Copy Markdown
Collaborator Author
  1. In Move non-ECS fields from root level event #897 there is also cluster_id do we want to change it on a different PR?

@amirbenun - Feels like it does not relate to the CNVM flow as we don't send this field.
I'll open a follow-up task for removing the cluster_id field (it has already an alternative - orchestrator.cluster.id), it will be a bit more complicated as it is a breaking change.

@kfirpeled

kfirpeled commented May 3, 2023

Copy link
Copy Markdown
Contributor

@kfirpeled do we want to backport this?

Yes, looking at the current implementation:

  • having package both in the root level and under vulnerability
  • moving type, target and class from the root level

We agree to backport that to 8.8

cc: @uri-weisman
It also means to fix the mappings in the integration

Out of scope for 8.8

  • Removing cluster_id
@uri-weisman
uri-weisman merged commit 67d4d16 into elastic:main May 4, 2023
@uri-weisman
uri-weisman deleted the fix_schema branch May 4, 2023 06:27
mergify Bot pushed a commit that referenced this pull request May 4, 2023
(cherry picked from commit 67d4d16)
uri-weisman added a commit that referenced this pull request May 4, 2023
Update CNVM findings schema (#912)

(cherry picked from commit 67d4d16)

Co-authored-by: Uri Weisman <68195305+uri-weisman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

4 participants